Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scripts/test-infra: drop the unused build-image script #1762

Merged
merged 1 commit into from
Jul 8, 2024
Merged

scripts/test-infra: drop the unused build-image script #1762

merged 1 commit into from
Jul 8, 2024

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Jul 8, 2024

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 8, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 8, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit f7f6bfa
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/668bbdcc602ebb0008f937da
😎 Deploy Preview https://deploy-preview-1762--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@marquiz
Copy link
Contributor Author

marquiz commented Jul 8, 2024

Pending kubernetes/test-infra#32916
/hold

/assign @ArangoGutierrez

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2024
ArangoGutierrez
ArangoGutierrez approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 8, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1717dc599f8a8571645a96368db7b5a3793d57ff

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 8, 2024 •
edited
Loading

@marquiz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-node-feature-discovery-build-image-generic f7f6bfa link true /test pull-node-feature-discovery-build-image-generic

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@marquiz
Copy link
Contributor Author

marquiz commented Jul 8, 2024

/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz, TessaIO

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@marquiz
Copy link
Contributor Author

marquiz commented Jul 8, 2024 •
edited
Loading

/unhold

ping @ArangoGutierrez

EDIT: oh, nevermind, it was already lgtm'd 🤦

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2024
@k8s-ci-robot k8s-ci-robot merged commit d84284a into kubernetes-sigs:master Jul 8, 2024
11 checks passed
@marquiz marquiz deleted the devel/test-infra-build-image branch July 8, 2024 15:22
@marquiz
Copy link
Contributor Author

marquiz commented Jul 9, 2024

/retest

@marquiz marquiz mentioned this pull request Dec 12, 2024
Closed
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArangoGutierrez ArangoGutierrez ArangoGutierrez approved these changes

@TessaIO TessaIO TessaIO approved these changes

@adrianchiris adrianchiris Awaiting requested review from adrianchiris

Assignees

@ArangoGutierrez ArangoGutierrez

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marquiz @k8s-ci-robot @ArangoGutierrez @TessaIO