Use worker DS OwnerReference for NF's

[ArangoGutierrez]

No description provided.

[netlify]

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name	Link
🔨 Latest commit	e33e68a
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/668d3654fff61f0008d38c49
😎 Deploy Preview	https://deploy-preview-1755--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[ArangoGutierrez]

/assign @marquiz

[adrianchiris]

lgtm

[marquiz]

/test pull-node-feature-discovery-verify-master

[marquiz]

/test pull-node-feature-discovery-verify-master

[k8s-infra-cherrypick-robot]

@ArangoGutierrez: once the present PR merges, I will cherry-pick it on top of release-0.15 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[marquiz]

/cherry-pick release-0.16

[k8s-infra-cherrypick-robot]

@marquiz: once the present PR merges, I will cherry-pick it on top of release-0.16 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[adrianchiris]

@ArangoGutierrez question regarding L825. if no change to NF spec will it still update the object to set owner reference ? just want to make sure that if we update NFD in the cluster (e.g helm upgrade -n ....), owner reference will be added to existing NF CRs.

[ArangoGutierrez]

DeepEqual evaluates the entire object, so the answer is yes, if this is a new pod, because XYZ reason, we would update the NF with the new ownerRef (if this changed)

[marquiz]

Yes, it updates the object if anything changes (including the object metadata)

[adrianchiris]

small question otherwise code LGTM

[ArangoGutierrez]

/test pull-node-feature-discovery-e2e-test-master

[marquiz]

Nice job @ArangoGutierrez. I think this is good to go

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 46d9fb78c5d2143815a0d5ee50474aceceabf9a3

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianchiris, ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[marquiz]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: aa0dc2aef50785e014d9be9f510e2b09da19b244

[k8s-infra-cherrypick-robot]

@ArangoGutierrez: #1755 failed to apply on top of branch "release-0.15":

Applying: Use worker DS OwnerReference for NF's
Applying: Add optionable arguments to NewWorker
Using index info to reconstruct a base tree...
M	cmd/nfd-worker/main.go
M	pkg/nfd-worker/nfd-worker-internal_test.go
M	pkg/nfd-worker/nfd-worker.go
M	pkg/nfd-worker/nfd-worker_test.go
M	test/e2e/utils/rbac.go
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/utils/rbac.go
Auto-merging pkg/nfd-worker/nfd-worker_test.go
Auto-merging pkg/nfd-worker/nfd-worker.go
CONFLICT (content): Merge conflict in pkg/nfd-worker/nfd-worker.go
Auto-merging pkg/nfd-worker/nfd-worker-internal_test.go
Auto-merging cmd/nfd-worker/main.go
CONFLICT (content): Merge conflict in cmd/nfd-worker/main.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 Add optionable arguments to NewWorker
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-0.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-infra-cherrypick-robot]

@marquiz: new pull request created: #1771

In response to this:

/cherry-pick release-0.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.