Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document AVXVNNIINT16 cpuid feature #1749

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Document AVXVNNIINT16 cpuid feature #1749

merged 1 commit into from
Jul 4, 2024

Conversation

ozhuraki
Copy link
Contributor

Update to klauspost/cpuid to v2.2.7

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 24, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @ozhuraki. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 24, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 24, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit cb80fec
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/668693159d6d9300081556de
😎 Deploy Preview https://deploy-preview-1749--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ArangoGutierrez
Copy link
Contributor

Hi @ozhuraki thanks for the contribution!!

Looks like Dependabot bumped the version for klauspost causing a merge conflict, could you fix it please?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 2, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 4, 2024
marquiz
marquiz reviewed Jul 4, 2024
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ozhuraki for the PR. The commit message (and PR title) should be changed to match the content of the PR. E.g. "Document AVXVNNIINT16 cpuid feature" or smth

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 4, 2024
@ozhuraki
Document AVXVNNIINT16 cpuid feature
cb80fec 
Signed-off-by: Oleg Zhurakivskyy <[email protected]>
@ozhuraki
Copy link
Contributor Author

ozhuraki commented Jul 4, 2024

@marquiz
Thanks, updated.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2024
marquiz
marquiz approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retitle Document AVXVNNIINT16 cpuid feature

@k8s-ci-robot k8s-ci-robot changed the title Support detection of AVXVNNIINT16 Document AVXVNNIINT16 cpuid feature Jul 4, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz, ozhuraki

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@marquiz
Copy link
Contributor

marquiz commented Jul 4, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 4, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2bba824169eba35c87a06f97303c10117ac6f65e

@k8s-ci-robot k8s-ci-robot merged commit 33c844c into kubernetes-sigs:master Jul 4, 2024
8 checks passed
@marquiz marquiz mentioned this pull request Dec 12, 2024
Open
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArangoGutierrez ArangoGutierrez ArangoGutierrez approved these changes

@marquiz marquiz marquiz approved these changes

@adrianchiris adrianchiris Awaiting requested review from adrianchiris

@fmuyassarov fmuyassarov Awaiting requested review from fmuyassarov

Assignees

@marquiz marquiz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ozhuraki @k8s-ci-robot @ArangoGutierrez @marquiz