nfd-master: fix resync period config option #1185

AhmedGrati · 2023-04-25T01:08:06Z

Resolves #1181.

How to test:

Make sure that CRDs have been deployed and then run locally

make build
NODE_NAME=<node-name> ./bin/nfd-master -kubeconfig $HOME/.kube/config -enable-nodefeature-api -resync-period=1s

netlify · 2023-04-25T01:08:13Z

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name	Link
🔨 Latest commit	`87c2d7e`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/6450f137282b370007d739fb
😎 Deploy Preview	https://deploy-preview-1185--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

AhmedGrati · 2023-04-25T01:08:38Z

/cc @marquiz

pkg/nfd-master/nfd-api-controller.go

pkg/nfd-master/nfd-master.go

marquiz

Doesn't fix the problem, -resync-period=1s still doesn't have any effect

pkg/nfd-master/nfd-api-controller.go

marquiz · 2023-04-25T06:55:12Z

Doesn't fix the problem, -resync-period=1s still doesn't have any effect

Ach, my test setup was broken. Seems to work now

marquiz

A few more comments. Please also remove the unused ResyncPeriod field from Args

pkg/nfd-master/nfd-master.go

marquiz · 2023-04-25T07:08:09Z

Not perfect yet:

$ NODE_NAME=mini-126 ./bin/nfd-master -kubeconfig $HOME/.kube/config -enable-nodefeature-api -config nfd-master.conf 
I0425 10:07:10.223536 1236969 nfd-master.go:184] Node Feature Discovery Master v0.14.0-devel-37-g3fed5ca5
I0425 10:07:10.223579 1236969 nfd-master.go:188] NodeName: "mini-126"
I0425 10:07:10.223587 1236969 nfd-master.go:189] Kubernetes namespace: ""
I0425 10:07:10.223754 1236969 nfd-master.go:1108] configuration file "nfd-master.conf" parsed
I0425 10:07:10.226718 1236969 nfd-master.go:1163] master (re-)configuration successfully completed
I0425 10:07:10.226731 1236969 nfd-master.go:1227] starting nfd api controller
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x1ac20f8]

goroutine 1 [running]:
sigs.k8s.io/node-feature-discovery/pkg/nfd-master.(*nfdMaster).startNfdControllerApi(0xc000cb0160)
	/home/marquiz/go/git/node-feature-discovery/review/pkg/nfd-master/nfd-master.go:1230 +0xf8
sigs.k8s.io/node-feature-discovery/pkg/nfd-master.(*nfdMaster).Run(0xc000cb0160)
	/home/marquiz/go/git/node-feature-discovery/review/pkg/nfd-master/nfd-master.go:201 +0x371
main.main()
	/home/marquiz/go/git/node-feature-discovery/review/cmd/nfd-master/main.go:95 +0x47b

AhmedGrati · 2023-04-25T08:14:10Z

@marquiz can you please send the content of nfd-master.conf?

marquiz · 2023-04-25T08:17:36Z

@marquiz can you please send the content of nfd-master.conf?

resyncPeriod: "1s"

pkg/nfd-master/nfd-master.go

AhmedGrati · 2023-04-25T16:22:10Z

Gotta add the e2e tests.

pkg/nfd-master/nfd-master.go

pkg/nfd-master/nfd-api-controller.go

marquiz · 2023-04-25T17:08:27Z

Gotta add the e2e tests.

That would be awesome to keep us safer going forward.

pkg/nfd-master/nfd-master.go

test/e2e/node_feature_discovery_test.go

k8s-ci-robot · 2023-04-28T12:14:17Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AhmedGrati, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

AhmedGrati · 2023-04-28T13:15:02Z

Thanks @AhmedGrati 🙏

/retitle nfd-master: fix resync period config option

One more ask: could you rebase on top of the latest master? Not related to this PR but we'd like to test the codecov reporting 🥸

Done 👌

marquiz · 2023-04-28T13:44:21Z

Sorry @AhmedGrati, one more rebase needed, not because of this PR (it is solid) but because of the codecov mess we've created 🙈
/unhold

marquiz · 2023-04-28T18:09:47Z

Thx @AhmedGrati !
/assign @ArangoGutierrez

ArangoGutierrez · 2023-04-28T18:36:49Z

it fails to me

I0428 18:36:16.513067       1 nfd-master.go:610] will process all nodes in the cluster
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x1abc1e8]

goroutine 121 [running]:
sigs.k8s.io/node-feature-discovery/pkg/nfd-master.(*nfdMaster).nfdAPIUpdateOneNode(0xc000143e00, {0xc000a83578, 0x8})
        /go/node-feature-discovery/pkg/nfd-master/nfd-master.go:633 +0x108
sigs.k8s.io/node-feature-discovery/pkg/nfd-master.(*nfdMaster).nfdAPIUpdateAllNodes(0xc000143e00)
        /go/node-feature-discovery/pkg/nfd-master/nfd-master.go:623 +0x170
sigs.k8s.io/node-feature-discovery/pkg/nfd-master.(*nfdMaster).nfdAPIUpdateHandler(0xc000143e00)
        /go/node-feature-discovery/pkg/nfd-master/nfd-master.go:346 +0x1cc
created by sigs.k8s.io/node-feature-discovery/pkg/nfd-master.(*nfdMaster).Run
        /go/node-feature-discovery/pkg/nfd-master/nfd-master.go:224 +0x53c

after editing the configMap to 1s, and waiting a couple seconds

AhmedGrati · 2023-04-28T18:40:42Z

it fails to me

I0428 18:36:16.513067       1 nfd-master.go:610] will process all nodes in the cluster
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x1abc1e8]

goroutine 121 [running]:
sigs.k8s.io/node-feature-discovery/pkg/nfd-master.(*nfdMaster).nfdAPIUpdateOneNode(0xc000143e00, {0xc000a83578, 0x8})
        /go/node-feature-discovery/pkg/nfd-master/nfd-master.go:633 +0x108
sigs.k8s.io/node-feature-discovery/pkg/nfd-master.(*nfdMaster).nfdAPIUpdateAllNodes(0xc000143e00)
        /go/node-feature-discovery/pkg/nfd-master/nfd-master.go:623 +0x170
sigs.k8s.io/node-feature-discovery/pkg/nfd-master.(*nfdMaster).nfdAPIUpdateHandler(0xc000143e00)
        /go/node-feature-discovery/pkg/nfd-master/nfd-master.go:346 +0x1cc
created by sigs.k8s.io/node-feature-discovery/pkg/nfd-master.(*nfdMaster).Run
        /go/node-feature-discovery/pkg/nfd-master/nfd-master.go:224 +0x53c

after editing the configMap to 1s, and waiting a couple seconds

@ArangoGutierrez can you please give me the command that u ran?

ArangoGutierrez · 2023-04-28T18:41:26Z

kubectl edit cm -n node-feature-discovery nfd-master-conf

AhmedGrati · 2023-04-28T19:07:08Z

Sorry @ArangoGutierrez but I tried to reproduce it on my local machine using tilt, but I had this error during the go install:

→ ../pkg/mod/k8s.io/[email protected]/pkg/authentication/token/cache/cached_token_authenticator.go:286:29: undefined: unsafe.StringData
→ ../pkg/mod/k8s.io/[email protected]/pkg/authentication/token/cache/cached_token_authenticator.go:297:16: undefined: unsafe.String
→ ../pkg/mod/k8s.io/[email protected]/pkg/authentication/token/cache/cached_token_authenticator.go:297:30: undefined: unsafe.SliceData

However, I depleted a NodeFeatureRule and I ran:

NODE_NAME=minikube ./bin/nfd-master -kubeconfig $HOME/.kube/config -enable-nodefeature-api -config nfd-master.conf

and I updated the nfd-master-conf, but there's no error.
Any kind of help to reproduce it would be much appreciated.

ArangoGutierrez · 2023-04-28T19:09:43Z

Sorry @ArangoGutierrez but I tried to reproduce it on my local machine using tilt, but I had this error during the go install:
→ ../pkg/mod/k8s.io/[email protected]/pkg/authentication/token/cache/cached_token_authenticator.go:286:29: undefined: unsafe.StringData
→ ../pkg/mod/k8s.io/[email protected]/pkg/authentication/token/cache/cached_token_authenticator.go:297:16: undefined: unsafe.String
→ ../pkg/mod/k8s.io/[email protected]/pkg/authentication/token/cache/cached_token_authenticator.go:297:30: undefined: unsafe.SliceData
However, I depleted a NodeFeatureRule and I ran:
NODE_NAME=minikube ./bin/nfd-master -kubeconfig $HOME/.kube/config -enable-nodefeature-api -config nfd-master.conf
and I updated the nfd-master-conf, but there's no error. Any kind of help to reproduce it would be much appreciated.

I am running make IMAGE_TAG_NAME=pr_1185 image push deploy
and then editing the configmap, I an not running it local, maybe that's the diff

AhmedGrati · 2023-04-28T19:48:28Z

@ArangoGutierrez I'm investigating it.

AhmedGrati · 2023-04-29T00:08:26Z

@ArangoGutierrez the problem is that because you ran it without using the -enable-nodefeature-api flag, that's why it's crashing. So it should be fixed, but I'm not sure that it's related to this PR. Even on the master branch, u can reproduce it, so I assume we should fix it in another PR. wdyt?

marquiz · 2023-05-02T07:29:22Z

Thanks @ArangoGutierrez for reporting this segfault.

the problem is that because you ran it without using the -enable-nodefeature-api flag, that's why it's crashing. So it should be fixed, but I'm not sure that it's related to this PR. Even on the master branch, u can reproduce it, so I assume we should fix it in another PR. wdyt?

We should never crash like this. It's related to the dynamic resync-period setting so I think it should be fixed in this PR. I guess the most straightforward fix would be to just add additional check for m.args.EnableNodeFeatureApi before signaling the the "update all" channel. Probably better would be to have safeguard e.g. in nfdAPIUpdateHandler.

This PR fixes the resync-period configuration option of the nfd-master. In fact, previously, changes were not reflected in the nfd-master at runtime. e2e tests are also implemented to make sure that the fix is already working as expected. Signed-off-by: AhmedGrati <[email protected]>

AhmedGrati · 2023-05-02T11:25:08Z

/cc @ArangoGutierrez

codecov · 2023-05-02T11:35:08Z

Codecov Report

Merging #1185 (87c2d7e) into master (e4dfa2d) will decrease coverage by 0.05%.
The diff coverage is 4.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1185      +/-   ##
==========================================
- Coverage   28.83%   28.79%   -0.05%     
==========================================
  Files          51       51              
  Lines        7102     7119      +17     
==========================================
+ Hits         2048     2050       +2     
- Misses       4845     4856      +11     
- Partials      209      213       +4

Impacted Files	Coverage Δ
pkg/nfd-master/nfd-api-controller.go	`10.11% <0.00%> (-0.12%)`	⬇️
pkg/nfd-master/nfd-master.go	`43.40% <5.55%> (-0.61%)`	⬇️

marquiz · 2023-05-02T15:18:36Z

looks good to me, ping @ArangoGutierrez

ArangoGutierrez

0502 18:10:23.985214       1 nfd-master.go:590] received labeling request for node "minikube"
I0502 18:11:11.463236       1 nfd-master.go:238] reloading configuration
I0502 18:11:11.463507       1 nfd-master.go:1119] configuration file "/etc/kubernetes/node-feature-discovery/nfd-master.conf" parsed
I0502 18:11:11.463561       1 nfd-master.go:1167] master (re-)configuration successfully completed
I0502 18:11:11.463626       1 nfd-master.go:245] stopping the nfd api controller
I0502 18:11:11.463647       1 nfd-master.go:1231] starting nfd api controller
I0502 18:11:23.952276       1 nfd-master.go:590] received labeling request for node "minikube"
I0502 18:12:23.973806       1 nfd-master.go:590] received labeling request for node "minikube"

ArangoGutierrez · 2023-05-02T18:13:05Z

/lgtm

k8s-ci-robot · 2023-05-02T18:13:13Z

LGTM label has been added.

Git tree hash: e28d1ddaec9fcddd6896920ca6a778af9e6224f8

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [node-feature-discovery](https://github.com/kubernetes-sigs/node-feature-discovery) | minor | `0.13.4` -> `0.14.0` | --- ### Release Notes <details> <summary>kubernetes-sigs/node-feature-discovery (node-feature-discovery)</summary> ### [`v0.14.0`](https://github.com/kubernetes-sigs/node-feature-discovery/releases/tag/v0.14.0) [Compare Source](kubernetes-sigs/node-feature-discovery@v0.13.4...v0.14.0) #### What's new ##### NodeFeature API The [NodeFeature](https://kubernetes-sigs.github.io/node-feature-discovery/v0.14/usage/custom-resources.html#nodefeature) API is now enabled by default. The new CRD-based API replaces the previous gRPC-based communication between nfd-master and nfd-worker and, reducing network traffic and allows changes in NodeFeatureRules to take effect immediately (independent of the sleep-interval of nfd-worker). NodeFeature API can also be used to implement 3rd party extensions, see [customization guide](https://kubernetes-sigs.github.io/node-feature-discovery/v0.14/usage/customization-guide#nodefeature-custom-resource) for more details. Garbage collection of stale NodeFeature objects was added in the form of nfd-gc daemon. The gRPC API is now deprecated and will be removed in a future release. The related command-line flags are also deprecated (and don't have any effect when NodeFeature API is in use): - nfd-master: `-ca-file`, `-cert-file`, `-key-file`, `-port`, `-verify-node-name` - nfd-worker: `-ca-file`, `-cert-file`, `-key-file`, `-server`, `-server-name-override` ##### Metrics NFD now provides Prometheus metrics for better observability. Also, the Helm and kustomize deployments support enabling metrics collection with the [Prometheus operator](https://github.com/prometheus-operator/prometheus-operator). See the [documentation](https://kubernetes-sigs.github.io/node-feature-discovery/v0.14/deployment/metrics.html) for more information about the available metrics and deployment instructions. ##### Hooks disabled by default The deprecation of nfd-worker [hooks](https://kubernetes-sigs.github.io/node-feature-discovery/v0.14/usage/customization-guide.html#hooks) continues, disabling them by default in v0.14. Potential users of hooks are encouraged to switch to use the NFD CRDs ([NodeFeature](https://kubernetes-sigs.github.io/node-feature-discovery/v0.14/usage/customization-guide.html#nodefeature-custom-resource) and [NodeFeatureRule](https://kubernetes-sigs.github.io/node-feature-discovery/v0.14/usage/customization-guide.html#nodefeaturerule-custom-resource)) or [feature files](https://kubernetes-sigs.github.io/node-feature-discovery/master/usage/customization-guide.html#feature-files). Hooks can still be enabled with the [`sources.local.hooksEnabled`](https://kubernetes-sigs.github.io/node-feature-discovery/master/reference/worker-configuration-reference.html#sourceslocalhooksenabled) configuration option. ##### Feature files **Expiry time:** NFD now supports specifying an expiry time for the features specified in a feature file, providing better lifecycle management for the feature labels. See the [documentation](https://kubernetes-sigs.github.io/node-feature-discovery/master/usage/customization-guide.html#input-format) for more details. **Size limit:** There is now a 64kB size limit for feature files. ##### Miscellaneous ##### NodeFeatureRule API Dynamic values for labels is now supported by using the `@` notation, see [documentation](https://kubernetes-sigs.github.io/node-feature-discovery/v0.14/usage/customization-guide.html#labels) for more details. ##### NFD-Master - support for leader election was added, enabling high-availability deployments with multiple-replicas of nfd-master (with the NodeFeature API enabled) - dynamically configurable logging parameters via the config file - configurable resync period for the CRD controller - parallelized node updates, speeding up simultaneous updates of large number of nodes (e.g. update in NodeFeatureRules in a big cluster), can be controlled with the [`-nfd-api-parallelism`](https://kubernetes-sigs.github.io/node-feature-discovery/v0.14/reference/master-commandline-reference.html#-nfd-api-parallelism) flag ##### CPU features Detection of Intel TDX guests is now supported. ##### Logging The project was migrated structured logging, making log messages more consistent, better machine parseable and enables future improvements in logging. ##### Support policy The project now officially documented it's supported versions and deprecation policy, see the [documentation](https://kubernetes-sigs.github.io/node-feature-discovery/v0.14/reference/versions.html) for details. #### List of PRs - test/e2e: use proper context ([#1154](kubernetes-sigs/node-feature-discovery#1154)) - deps: Update kubernetes to v1.27.1 ([#1155](kubernetes-sigs/node-feature-discovery#1155)) - generate: update k8s code-generator to v0.27.1 ([#1156](kubernetes-sigs/node-feature-discovery#1156)) - generate: update protoc to v22.3 ([#1157](kubernetes-sigs/node-feature-discovery#1157)) - generate: update controller-gen to v0.11.3 ([#1158](kubernetes-sigs/node-feature-discovery#1158)) - generate: update mockery to v2.25.1 ([#1159](kubernetes-sigs/node-feature-discovery#1159)) - nfd-master: support noPublish with -prune ([#1161](kubernetes-sigs/node-feature-discovery#1161)) - nfd-master: fix -prune ([#1160](kubernetes-sigs/node-feature-discovery#1160)) - nfd-master: don't create emtpy annotations ([#1166](kubernetes-sigs/node-feature-discovery#1166)) - nfd-master: fix a crash when processing NodeFeatureRules ([#1173](kubernetes-sigs/node-feature-discovery#1173)) - pkg/nfd-master/nfd-master.go: Fix typo ([#1171](kubernetes-sigs/node-feature-discovery#1171)) - nfd-master: reject malformed extended resource dynamic capacity assignment ([#1169](kubernetes-sigs/node-feature-discovery#1169)) - go.mod: update deps ([#1178](kubernetes-sigs/node-feature-discovery#1178)) - OWNERS: add ArangoGutierrez as an approver ([#1180](kubernetes-sigs/node-feature-discovery#1180)) - feat: add master resync period configurability ([#1139](kubernetes-sigs/node-feature-discovery#1139)) - nfd-topology-updater: fix wrong kubelet_internal_checkpoint path and compare basename to full path ([#1167](kubernetes-sigs/node-feature-discovery#1167)) - docs: add missing .md suffix to internal references ([#1189](kubernetes-sigs/node-feature-discovery#1189)) - nfd-master: log node name when processing NodeFeatureRules ([#1191](kubernetes-sigs/node-feature-discovery#1191)) - scripts/test-infra: provide PR info to codecov ([#1194](kubernetes-sigs/node-feature-discovery#1194)) - Match usage and example for prepare-release.sh ([#1196](kubernetes-sigs/node-feature-discovery#1196)) - apis/nfd: add unit tests for Feature type ([#1190](kubernetes-sigs/node-feature-discovery#1190)) - Update README to v0.13.1 ([#1197](kubernetes-sigs/node-feature-discovery#1197)) - scripts/test-infra: provide PR base SHA to codecov ([#1199](kubernetes-sigs/node-feature-discovery#1199)) - codecov: drop required minimum coverage ratio of a commit to 0% ([#1200](kubernetes-sigs/node-feature-discovery#1200)) - codecov: drop required minimum coverage ratio at patch level ([#1201](kubernetes-sigs/node-feature-discovery#1201)) - nfd-master: refactor api-controller object handling ([#1198](kubernetes-sigs/node-feature-discovery#1198)) - nfd-master: refactor filtering of labels, taints and ERs ([#1202](kubernetes-sigs/node-feature-discovery#1202)) - helm: fix mount for nfd-master config ([#1204](kubernetes-sigs/node-feature-discovery#1204)) - nfd-master: fix resync period config option ([#1185](kubernetes-sigs/node-feature-discovery#1185)) - deployment/helm: fix default for kubeletStateDir parameter ([#1207](kubernetes-sigs/node-feature-discovery#1207)) - deployment/kustomize: drop pod-resources mount for topology-updater ([#1208](kubernetes-sigs/node-feature-discovery#1208)) - test/e2e: refactor matching of node properties ([#1184](kubernetes-sigs/node-feature-discovery#1184)) - deployment/helm: avoid overlapping mount paths on topology-updater ([#1212](kubernetes-sigs/node-feature-discovery#1212)) - deployment/helm: user dedicated serviceaccount for topology-updater ([#1213](kubernetes-sigs/node-feature-discovery#1213)) - deployment/helm: improve handling of topologyUpdater.kubeletStateFiles ([#1211](kubernetes-sigs/node-feature-discovery#1211)) - topology-updater: use node IP in the default configz URI ([#1218](kubernetes-sigs/node-feature-discovery#1218)) - e2e: delete CRs only if found ([#1221](kubernetes-sigs/node-feature-discovery#1221)) - Add leader election for nfd-master ([#1219](kubernetes-sigs/node-feature-discovery#1219)) - Fixed typo in Header under deployment/kustomize.md ([#1222](kubernetes-sigs/node-feature-discovery#1222)) - nfd-master: use close for stop channel ([#1227](kubernetes-sigs/node-feature-discovery#1227)) - scripts/test-infra: bump golangci-lint to v1.52.2 ([#1230](kubernetes-sigs/node-feature-discovery#1230)) - nfd-master: add validation of label names and values ([#1228](kubernetes-sigs/node-feature-discovery#1228)) - Migrate to structured logging ([#1223](kubernetes-sigs/node-feature-discovery#1223)) - scripts/test-infra: add logcheck to verify script ([#1235](kubernetes-sigs/node-feature-discovery#1235)) - Update README to v0.13.2 ([#1238](kubernetes-sigs/node-feature-discovery#1238)) - github: update new-release issue template ([#1239](kubernetes-sigs/node-feature-discovery#1239)) - feat: support dynamic values for labels in the NodeFeatureRule ([#1226](kubernetes-sigs/node-feature-discovery#1226)) - feat: parallelize nodes update ([#1133](kubernetes-sigs/node-feature-discovery#1133)) - cpu: Discover TDX guests based on cpuid information ([#1240](kubernetes-sigs/node-feature-discovery#1240)) - deployment/kustomize: use a named port for nfd gRPC service ([#1243](kubernetes-sigs/node-feature-discovery#1243)) - Fix missing apostrophe for jq ([#1245](kubernetes-sigs/node-feature-discovery#1245)) - Fix a typo on nfd-master cmd ([#1244](kubernetes-sigs/node-feature-discovery#1244)) - Removal of the bases field as it is deprecated by kustomize ([#1246](kubernetes-sigs/node-feature-discovery#1246)) - Docs: Fix typo on customization-guide ([#1247](kubernetes-sigs/node-feature-discovery#1247)) - hooks: disable hooks by default from v0.14 ([#1182](kubernetes-sigs/node-feature-discovery#1182)) - Remove pkg's imported twice ([#1248](kubernetes-sigs/node-feature-discovery#1248)) - fix typo in helm chart ([#1253](kubernetes-sigs/node-feature-discovery#1253)) - Stop ticker in time to avoid memory leak ([#1255](kubernetes-sigs/node-feature-discovery#1255)) - nfd-master: check for nil references in nfdAPIUpdateAllNodes ([#1258](kubernetes-sigs/node-feature-discovery#1258)) - cpu: Take cgroupsv1 into account when reading misc.capacity ([#1265](kubernetes-sigs/node-feature-discovery#1265)) - go.mod: update kubernetes to v1.27.4 ([#1268](kubernetes-sigs/node-feature-discovery#1268)) - github: update assignees in new-release issue template ([#1274](kubernetes-sigs/node-feature-discovery#1274)) - Enable metrics via prometheus operator ([#1242](kubernetes-sigs/node-feature-discovery#1242)) - README: update to v0.13.3 ([#1276](kubernetes-sigs/node-feature-discovery#1276)) - docs: document version and deprecation policy ([#1279](kubernetes-sigs/node-feature-discovery#1279)) - docs: fix toc of topology-updater and topology-gc reference ([#1278](kubernetes-sigs/node-feature-discovery#1278)) - docs: remove useless TOCs ([#1280](kubernetes-sigs/node-feature-discovery#1280)) - Add optional labels to the podmonitor ([#1282](kubernetes-sigs/node-feature-discovery#1282)) - docs: describe supported Kubernetes versions ([#1277](kubernetes-sigs/node-feature-discovery#1277)) - docs: deprecation policy for Helm chart params ([#1283](kubernetes-sigs/node-feature-discovery#1283)) - Fix Topology Manager policy and scope not being updated after NRT creation ([#1256](kubernetes-sigs/node-feature-discovery#1256)) - generate: bump tools to their latest versions ([#1284](kubernetes-sigs/node-feature-discovery#1284)) - Improve metrics ([#1288](kubernetes-sigs/node-feature-discovery#1288)) - docs: align metrics documentation with latest changes on naming ([#1289](kubernetes-sigs/node-feature-discovery#1289)) - docs: unify formatting of NOTEs ([#1292](kubernetes-sigs/node-feature-discovery#1292)) - source/local: trim whitespace from input ([#1293](kubernetes-sigs/node-feature-discovery#1293)) - source/local: support comments in input ([#1294](kubernetes-sigs/node-feature-discovery#1294)) - nfd-master: use term node update instead of labeling ([#1291](kubernetes-sigs/node-feature-discovery#1291)) - docs: document -metrics flag in command line reference ([#1296](kubernetes-sigs/node-feature-discovery#1296)) - fix empty hugepages in some numa nodes caused no such file or directory errors ([#1287](kubernetes-sigs/node-feature-discovery#1287)) - scripts/test-infra: update logcheck tool to v0.6.0 ([#1299](kubernetes-sigs/node-feature-discovery#1299)) - scripts/test-infra: bump golangci-lint to v1.54.0 ([#1300](kubernetes-sigs/node-feature-discovery#1300)) - Update kubernetes to v1.28.0 ([#1302](kubernetes-sigs/node-feature-discovery#1302)) - docs: update github-pages gem to v228 ([#1303](kubernetes-sigs/node-feature-discovery#1303)) - topology-gc: fix Stop ([#1306](kubernetes-sigs/node-feature-discovery#1306)) - topology-gc: rename run() ([#1309](kubernetes-sigs/node-feature-discovery#1309)) - topology-gc: rename runGC to garbageCollect() ([#1310](kubernetes-sigs/node-feature-discovery#1310)) - nfd-topology-updater: add metrics support ([#1295](kubernetes-sigs/node-feature-discovery#1295)) - topology-gc: refactor unit tests ([#1307](kubernetes-sigs/node-feature-discovery#1307)) - topology-gc: move initial GC out of startNodeInformer() ([#1308](kubernetes-sigs/node-feature-discovery#1308)) - topology-gc: simplify listing of node objects ([#1311](kubernetes-sigs/node-feature-discovery#1311)) - metrics: additional metrics for nfd-master ([#1290](kubernetes-sigs/node-feature-discovery#1290)) - Garbage collection of NodeFeature objects ([#1305](kubernetes-sigs/node-feature-discovery#1305)) - topology-updater: make -version always runnable ([#1297](kubernetes-sigs/node-feature-discovery#1297)) - go.mod: update kubernetes to v1.28.1 ([#1315](kubernetes-sigs/node-feature-discovery#1315)) - Makefile: increase golangci-lint timeout to 10min ([#1320](kubernetes-sigs/node-feature-discovery#1320)) - docs: use ruby docker image for building docs ([#1319](kubernetes-sigs/node-feature-discovery#1319)) - README: update to v0.13.4 ([#1324](kubernetes-sigs/node-feature-discovery#1324)) - test: add node updater pool unit tests ([#1252](kubernetes-sigs/node-feature-discovery#1252)) - docs: nfd-updater: clarify accounting ([#1321](kubernetes-sigs/node-feature-discovery#1321)) - nfd-updater: events: enable timer-only flow ([#1325](kubernetes-sigs/node-feature-discovery#1325)) - docs: demote hooks in the customization guide ([#1326](kubernetes-sigs/node-feature-discovery#1326)) - Feat: add expiry date for feature files ([#1285](kubernetes-sigs/node-feature-discovery#1285)) - Dockerfile: bump grpc-health-probe to v0.4.19 ([#1327](kubernetes-sigs/node-feature-discovery#1327)) - e2e/test: make the nfd-gc test pass on one-node cluster ([#1328](kubernetes-sigs/node-feature-discovery#1328)) - Enable NodeFeature API by default ([#1329](kubernetes-sigs/node-feature-discovery#1329)) - tls.md: Add note ([#1332](kubernetes-sigs/node-feature-discovery#1332)) - nfd_gc_test.go: fix multiple import of same pkg ([#1333](kubernetes-sigs/node-feature-discovery#1333)) - feat: add feature file size limit ([#1335](kubernetes-sigs/node-feature-discovery#1335)) - sources/custom: convert static rules to new format ([#1336](kubernetes-sigs/node-feature-discovery#1336)) - nfd-master: add config file options for logging ([#1338](kubernetes-sigs/node-feature-discovery#1338)) - Deprecate gRPC API ([#1334](kubernetes-sigs/node-feature-discovery#1334)) - Helm: conditionally add annotations if defined ([#1331](kubernetes-sigs/node-feature-discovery#1331)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.home/nrdufour/home-ops/pulls/78 Co-authored-by: Renovate <[email protected]> Co-committed-by: Renovate <[email protected]>

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 25, 2023

k8s-ci-robot requested review from ArangoGutierrez and zvonkok April 25, 2023 01:08

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 25, 2023

k8s-ci-robot requested a review from marquiz April 25, 2023 01:08

ArangoGutierrez requested changes Apr 25, 2023

View reviewed changes

pkg/nfd-master/nfd-api-controller.go Outdated Show resolved Hide resolved

pkg/nfd-master/nfd-master.go Outdated Show resolved Hide resolved

marquiz requested changes Apr 25, 2023

View reviewed changes

pkg/nfd-master/nfd-api-controller.go Outdated Show resolved Hide resolved