test/e2e: wait for CRD deletion to complete #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wait for the deletion of NFD CRDs to complete before trying to re-create them. Prevents errors in case CRDs already exist on the cluster when e2e-tests are launched.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
k8s-ci-robot
added
the
cncf-cla: yes
|
/assign @ArangoGutierrez |
k8s-ci-robot
added
the
size/S
|
Got this error while running the e2e locally, weird... given this patch doesn't touch that section Summarizing 1 Failure:
[FAIL] [kubernetes-sigs] NFD master and worker when running NFD with NodeFeature CRD API enabled when deploying a single nfd-master pod and NodeFeature objects deployed [It] denied labels should not be created by the NodeFeature object
/home/eduardo/SDK/github/kubernetes-sigs/node-feature-discovery/test/e2e/node_feature_discovery_test.go:659
Ran 12 of 263 Specs in 381.548 seconds
FAIL! -- 11 Passed | 1 Failed | 0 Pending | 251 Skipped
--- FAIL: TestE2E (381.55s) |
After rebasing this patch on top of current master, all works as expected |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 9845be64bc76f92ff36242661f28a881d3b09236
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait for the deletion of NFD CRDs to complete before trying to re-create them. Prevents errors in case CRDs already exist on the cluster when e2e-tests are launched.