Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

source/cpu: fix build flags of cpuid detection #1063

Merged
merged 1 commit into from
Feb 20, 2023
Merged

source/cpu: fix build flags of cpuid detection #1063

merged 1 commit into from
Feb 20, 2023

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Feb 17, 2023

Non-x86_64 platforms are virtually only buildable on Linux because the getauxval() glibc function is missing on many platforms.

@marquiz
source/cpu: fix build flags of cpuid detection
52fcf0b 
Non-x86_64 platforms are virtually only buildable on Linux because the
getauxval() glibc function is missing on many platforms.
@netlify
Copy link

netlify bot commented Feb 17, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 52fcf0b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/63efda86b7b5f400088d3491
😎 Deploy Preview https://deploy-preview-1063--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot requested review from kad and zvonkok February 17, 2023 19:50
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 17, 2023
@marquiz
Copy link
Contributor Author

marquiz commented Feb 17, 2023

Quick Friday night hack. Need to verify/think twice this doesn't break anything
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2023
@marquiz marquiz mentioned this pull request Feb 17, 2023
Closed
@marquiz
Copy link
Contributor Author

marquiz commented Feb 20, 2023

Works for x86_64 (linux and darwin) and arm64 darwin
/unhold
/assign @ArangoGutierrez @zvonkok

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2023
@marquiz
Copy link
Contributor Author

marquiz commented Feb 20, 2023

ping @yselkowitz @lubinszARM

ArangoGutierrez
ArangoGutierrez approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f25123c629cf633bd2fc052ab04b2d45decded46

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6235de0 into kubernetes-sigs:master Feb 20, 2023
@ArangoGutierrez ArangoGutierrez deleted the fixes/darwin-arm64 branch February 20, 2023 09:46
@marquiz
Copy link
Contributor Author

marquiz commented Mar 31, 2023

/cherry-pick release-0.12

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Mar 31, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link

@marquiz: new pull request created: #1104

In response to this:

/cherry-pick release-0.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marquiz marquiz mentioned this pull request Apr 12, 2023
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArangoGutierrez ArangoGutierrez ArangoGutierrez approved these changes

@kad kad Awaiting requested review from kad

@zvonkok zvonkok Awaiting requested review from zvonkok

Assignees

@zvonkok zvonkok

@ArangoGutierrez ArangoGutierrez

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marquiz @k8s-ci-robot @k8s-infra-cherrypick-robot @ArangoGutierrez @zvonkok