Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: move out unit testing from Dockerfile #1047

Merged
merged 1 commit into from
Feb 3, 2023
Merged

test: move out unit testing from Dockerfile #1047

merged 1 commit into from
Feb 3, 2023

Conversation

fmuyassarov
Copy link
Member

Move out running unit tests as part of container image building and
instead add it into verify.sh script which runs linter, formatter and
other checks. As a future improvement, we could have separate
Prow jobs for fmt, golangci-lint, helm-linter and unit tests separately.

@fmuyassarov
test: move out unit testing from Dockerfile
ae25d53 
Move out running unit tests as part of container image building and
instead add it into verify.sh script which runs linter, formatter
and other checks.

Signed-off-by: Muyassarov, Feruzjon <[email protected]>
@netlify
Copy link

netlify bot commented Feb 1, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit ae25d53
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/63daf04480e28100090db7f8
😎 Deploy Preview https://deploy-preview-1047--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 1, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 1, 2023
@fmuyassarov
Copy link
Member Author

/cc @marquiz

@k8s-ci-robot k8s-ci-robot requested a review from marquiz February 2, 2023 09:22
ArangoGutierrez
ArangoGutierrez approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Could you create an issue for
"As a future improvement, we could have separate
Prow jobs for fmt, golangci-lint, helm-linter and unit tests separately."
Otherwise, looks good to me

@ArangoGutierrez
Copy link
Contributor

/assign @marquiz

marquiz
marquiz approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fmuyassarov 👍 Makes sense (and the future improvements too)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, fmuyassarov, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2023
@ArangoGutierrez
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 3, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: facb6cf99c4ece78a542cdc5fef3b6071e907a66

@k8s-ci-robot k8s-ci-robot merged commit 7ca2353 into kubernetes-sigs:master Feb 3, 2023
@fmuyassarov fmuyassarov deleted the decouple-unit-test branch February 6, 2023 16:39
@fmuyassarov
Copy link
Member Author

Thanks! Could you create an issue for "As a future improvement, we could have separate Prow jobs for fmt, golangci-lint, helm-linter and unit tests separately." Otherwise, looks good to me

@ArangoGutierrez Sure and sorry, I somehow missed your comment :).

@marquiz marquiz mentioned this pull request Apr 12, 2023
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArangoGutierrez ArangoGutierrez ArangoGutierrez approved these changes

@marquiz marquiz marquiz approved these changes

@kad kad Awaiting requested review from kad

Assignees

@marquiz marquiz

@ArangoGutierrez ArangoGutierrez

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fmuyassarov @ArangoGutierrez @k8s-ci-robot @marquiz