set GANESHA_VERSION from Dockerfile #122

revant · 2023-03-06T08:50:16Z

Proposed fix for #115

This will publish image on ghcr.io instead of registry.k8s.io.

I was able to build and publish image here https://github.com/revant/nfs-ganesha-server-and-external-provisioner/actions/runs/4340538329/jobs/7579174476 and it was published successfully on ghcr.

At this moment the registry credentials are configured for ghcr.

To use registry.k8s.io I can change the tags for the docker build steps, It will not work without authentication.

Additional references to image in the repo will also need to change.

Are there any ENV vars that I can already use for registry.k8s.io?

k8s-ci-robot · 2023-03-06T08:50:22Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: revant
Once this PR has been reviewed and has the lgtm label, please assign jsafrane for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

linux-foundation-easycla · 2023-03-06T08:50:23Z

The committers listed above are authorized under a signed CLA.

✅ login: revant / name: Revant Nandgaonkar (618dc7d, 5e8b2b5)

k8s-ci-robot · 2023-03-06T08:50:23Z

Welcome @revant!

It looks like this is your first PR to kubernetes-sigs/nfs-ganesha-server-and-external-provisioner 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/nfs-ganesha-server-and-external-provisioner has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

revant · 2023-03-06T09:10:17Z

@kvaps

I can change the references to images in following files?

12 results - 9 files

charts/nfs-server-provisioner/README.md:
  60: | `image.repository`             | The image repository to pull from                                                                               | `k8s.gcr.io/sig-storage/nfs-provisioner:v4.0.8`         |

charts/nfs-server-provisioner/values.yaml:
  10:   repository: k8s.gcr.io/sig-storage/nfs-provisioner

deploy/kubernetes/deployment.yaml:
  66:           image: k8s.gcr.io/sig-storage/nfs-provisioner:v4.0.8

deploy/kubernetes/pod.yaml:
  14:       image: k8s.gcr.io/sig-storage/nfs-provisioner:v4.0.8

deploy/kubernetes/statefulset.yaml:
  66:           image: k8s.gcr.io/sig-storage/nfs-provisioner:v4.0.8

docs/deployment.md:
   32: $ docker pull k8s.gcr.io/sig-storage/nfs-provisioner:v4.0.8
   90: k8s.gcr.io/sig-storage/nfs-provisioner:v4.0.8 \
   98: k8s.gcr.io/sig-storage/nfs-provisioner:v4.0.8 \
  113: k8s.gcr.io/sig-storage/nfs-provisioner:v4.0.8 \

test/e2e/testing-manifests/deployment.yaml:
  66:           image: k8s.gcr.io/sig-storage/nfs-provisioner:v4.0.8

test/e2e/testing-manifests/pod.yaml:
  14:       image: k8s.gcr.io/sig-storage/nfs-provisioner:v4.0.8

test/e2e/testing-manifests/statefulset.yaml:
  66:           image: k8s.gcr.io/sig-storage/nfs-provisioner:v4.0.8

What about authentication for registry.k8s.io? Any idea what changes to be done for that?

Edit: found this https://github.com/kubernetes/registry.k8s.io#registryk8sio -> https://github.com/kubernetes/k8s.io/tree/main/k8s.gcr.io#managing-kubernetes-container-registries, Trying to understand it.

.github/workflows/docker-build.yml

kvaps · 2023-03-07T11:30:59Z

Thanks for proposed changes, I'd like to know is there any opportunity to push images into registry.k8s.io. Unfortunately I have not much time for elaborating this, so I asked a question in #sig-storage

ref https://kubernetes.slack.com/archives/C09QZFCE5/p1678188485825369

FYI

revant · 2023-03-07T12:07:54Z

My understanding after reading the links.

image is pushed to "staging" container registry. Requirements: https://github.com/kubernetes/k8s.io/tree/main/k8s.gcr.io#requirements
PR to github.com/kubernetes/k8s.io repo with specified yamls.
PR to respective repo to create google group? (not sure)

It seems all the other yamls in that repo are using gcr.io, I don't know if ghcr.io can be used as staging.

In case gcr needs to be used there is a documentation here: https://github.com/kubernetes/test-infra/blob/master/config/jobs/image-pushing/README.md, It says we need a cloudbuild.yaml in this repo and a cookie-cutter prow job config placed there.

kvaps · 2023-03-07T13:03:06Z

Hey. Yeah, I requested changes in upstream for creating google group and staging repo:
kubernetes/k8s.io#4881 (comment)

However non of active maintainers are not member of kubernetes-org, I requested to add myself:
kubernetes/org#4079

kvaps · 2023-03-07T20:40:47Z

Okay it seems we have a staging repo:

gcr.io/k8s-staging-sig-storage/nfs-provisioner

Now we need to configure automatic push into it

https://github.com/kubernetes/test-infra/blob/master/config/jobs/image-pushing/README.md

revant · 2023-03-08T12:00:16Z

There is already a cloudbuild.yaml and it seems to run ./.cloudbuild.sh. It seems to be a boilerplate.

I'm trying to figure out how I can verify execution of steps from cloudbuild.yaml.

I was able to verify github actions on my github fork.

revant · 2023-03-08T12:54:42Z

I guess the ./.cloudbuild.sh works. I tried it locally. It builds the image locally, the push part doesn't work due to auth

cd nfs-ganesha-server-and-external-provisioner
docker run --rm -it -v ${PWD}:/workspace -v /var/run/docker.sock:/var/run/docker.sock --entrypoint=bash gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20211118-2f2d816b90
# In container
cd /workspace
export PULL_BASE_REF=master
export REGISTRY_NAME=gcr.io/k8s-staging-sig-storage
./.cloudbuild.sh

###

 > exporting to image:
------
error: failed to solve: failed to push gcr.io/k8s-staging-sig-storage/nfs-provisioner:amd64-linux-canary: error getting credentials - err: exit status 1, out: `You do not currently have an active account selected. See https://cloud.google.com/sdk/docs/authorizing for more information.`
+ docker buildx rm multiarchimage-buildertest
make: *** [release-tools/build.make:149: push-multiarch-nfs-provisioner] Error 1

I think it should work as expected for builds at least. I've to figure out about tags. It tags as amd64-linux-canary instead it should be GANESHA_VERSION

Edit:

build.make:

# A release image "vX.Y.Z" gets built if there is a tag of that format for the current commit.
# --abbrev=0 suppresses long format, only showing the closest tag.
IMAGE_TAGS+=$(shell tagged="$$(git describe --tags --match='v*' --abbrev=0)"; if [ "$$tagged" ] && [ "$$(git rev-list -n1 HEAD)" = "$$(git rev-list -n1 $$tagged)" ]; then echo $$tagged; fi)

It should pick up the tag from git repo.

revant · 2023-03-08T15:23:44Z

In that case the only useful change that the PR does is use a step for Set ganesha version and use env.GANESHA_VERSION instead of tag.

compile nfs-provisioner and build final image happens on cloudbuild. I'll revert the steps.

revant · 2023-03-12T07:00:16Z

Why does the build process uses github actions for base image and cloud build for final image?

Shouldn't it be completely done on cloudbuild?

What if new version tag for base image is in build process (takes around 2hrs) and cloudbuild tries to build final image based on new version tag and doesn't find the image on ghcr.io yet? Or this scenario will not happen?

k8s-triage-robot · 2023-06-10T07:59:55Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2023-07-10T08:27:48Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

revant added 2 commits March 6, 2023 11:44

ci: build image with nfs-provisioner

618dc7d

ci: change workflow name

5e8b2b5

k8s-ci-robot requested review from kvaps and wongma7 March 6, 2023 08:50

jglick reviewed Mar 6, 2023

View reviewed changes

.github/workflows/docker-build.yml Outdated Show resolved Hide resolved

ci: use ganesha version from dockerfile

71fc191

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 6, 2023

revant added 2 commits March 6, 2023 19:12

fix: github action name

1c28597

fix: use correct github action env var

f24636d

jglick reviewed Mar 6, 2023

View reviewed changes

.github/workflows/docker-build.yml Outdated Show resolved Hide resolved

.github/workflows/docker-build.yml Outdated Show resolved Hide resolved

ci: delete version sync comments

ca4ba34

kvaps mentioned this pull request Mar 7, 2023

add kvaps to kubernetes org kubernetes/org#4079

Merged

ci: remove cloud build steps

2743a17

k8s-ci-robot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 8, 2023

k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 8, 2023

revant changed the title ~~Build base image + nfs-provisioner~~ set GANESHA_VERSION from Dockerfile Mar 8, 2023

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 10, 2023

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 10, 2023

revant closed this Jul 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

set GANESHA_VERSION from Dockerfile #122

set GANESHA_VERSION from Dockerfile #122

revant commented Mar 6, 2023

k8s-ci-robot commented Mar 6, 2023

linux-foundation-easycla bot commented Mar 6, 2023 •

edited

Loading

k8s-ci-robot commented Mar 6, 2023

revant commented Mar 6, 2023 •

edited

Loading

kvaps commented Mar 7, 2023

revant commented Mar 7, 2023 •

edited

Loading

kvaps commented Mar 7, 2023 •

edited

Loading

kvaps commented Mar 7, 2023 •

edited

Loading

revant commented Mar 8, 2023

revant commented Mar 8, 2023 •

edited

Loading

revant commented Mar 8, 2023 •

edited

Loading

revant commented Mar 12, 2023

k8s-triage-robot commented Jun 10, 2023

k8s-triage-robot commented Jul 10, 2023

set GANESHA_VERSION from Dockerfile #122

set GANESHA_VERSION from Dockerfile #122

Conversation

revant commented Mar 6, 2023

k8s-ci-robot commented Mar 6, 2023

linux-foundation-easycla bot commented Mar 6, 2023 • edited Loading

k8s-ci-robot commented Mar 6, 2023

revant commented Mar 6, 2023 • edited Loading

kvaps commented Mar 7, 2023

revant commented Mar 7, 2023 • edited Loading

kvaps commented Mar 7, 2023 • edited Loading

kvaps commented Mar 7, 2023 • edited Loading

revant commented Mar 8, 2023

revant commented Mar 8, 2023 • edited Loading

revant commented Mar 8, 2023 • edited Loading

revant commented Mar 12, 2023

k8s-triage-robot commented Jun 10, 2023

k8s-triage-robot commented Jul 10, 2023

linux-foundation-easycla bot commented Mar 6, 2023 •

edited

Loading

revant commented Mar 6, 2023 •

edited

Loading

revant commented Mar 7, 2023 •

edited

Loading

kvaps commented Mar 7, 2023 •

edited

Loading

kvaps commented Mar 7, 2023 •

edited

Loading

revant commented Mar 8, 2023 •

edited

Loading

revant commented Mar 8, 2023 •

edited

Loading