[Policy Assistant] fix: npv1 deny-all simulation #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hunter Gregory <[email protected]>
Signed-off-by: Hunter Gregory <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: huntergregory The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
✅ Deploy Preview for kubernetes-sigs-network-policy-api ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Hunter Gregory <[email protected]>
k8s-ci-robot
added
size/L
|
/lgtm Nice one @huntergregory ! |
k8s-ci-robot
added
the
lgtm
huntergregory
added a commit
to huntergregory/network-policy-api
that referenced
this pull request
Aug 8, 2024
…ernetes-sigs#240 (building policies) Signed-off-by: Hunter Gregory <[email protected]>
huntergregory
added a commit
to huntergregory/network-policy-api
that referenced
this pull request
Aug 8, 2024
…s#241 (explain output) Signed-off-by: Hunter Gregory <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #211. Now the simulation for a NetworkPolicy (v1) without any ingress/egress rules would properly deny traffic (if no other NetPols allow traffic).
Also updates wording for the explain table from "NPv1: All peers allowed" to "NPv1: Allow any peers". Saying "all peers" doesn't seem right in case there are no peers?
Tests: