Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the text about duplicate priority values #229

Merged
merged 1 commit into from
May 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions apis/v1alpha1/adminnetworkpolicy_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,14 @@ type AdminNetworkPolicyStatus struct {

// AdminNetworkPolicySpec defines the desired state of AdminNetworkPolicy.
type AdminNetworkPolicySpec struct {
// Priority is a value from 0 to 1000. Rules with lower priority values have
// higher precedence, and are checked before rules with higher priority values.
// Priority is a value from 0 to 1000. Policies with lower priority values have
// higher precedence, and are checked before policies with higher priority values.
// All AdminNetworkPolicy rules have higher precedence than NetworkPolicy or
// BaselineAdminNetworkPolicy rules
// The behavior is undefined if two ANP objects have same priority.
// Every AdminNetworkPolicy should have a unique priority value; if two (or more)
// policies with the same priority could both match a connection, then the
// implementation can apply any of the matching policies to the connection, and
// there is no way for the user to reliably determine which one it will choose.
//
// Support: Core
//
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -817,11 +817,14 @@ spec:
type: array
priority:
description: |-
Priority is a value from 0 to 1000. Rules with lower priority values have
higher precedence, and are checked before rules with higher priority values.
Priority is a value from 0 to 1000. Policies with lower priority values have
higher precedence, and are checked before policies with higher priority values.
All AdminNetworkPolicy rules have higher precedence than NetworkPolicy or
BaselineAdminNetworkPolicy rules
The behavior is undefined if two ANP objects have same priority.
Every AdminNetworkPolicy should have a unique priority value; if two (or more)
policies with the same priority could both match a connection, then the
implementation can apply any of the matching policies to the connection, and
there is no way for the user to reliably determine which one it will choose.


Support: Core
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -701,11 +701,14 @@ spec:
type: array
priority:
description: |-
Priority is a value from 0 to 1000. Rules with lower priority values have
higher precedence, and are checked before rules with higher priority values.
Priority is a value from 0 to 1000. Policies with lower priority values have
higher precedence, and are checked before policies with higher priority values.
All AdminNetworkPolicy rules have higher precedence than NetworkPolicy or
BaselineAdminNetworkPolicy rules
The behavior is undefined if two ANP objects have same priority.
Every AdminNetworkPolicy should have a unique priority value; if two (or more)
policies with the same priority could both match a connection, then the
implementation can apply any of the matching policies to the connection, and
there is no way for the user to reliably determine which one it will choose.


Support: Core
Expand Down
Loading