-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherrypick pull request #884 from shuaich/remove_elevated_permission to release-0.5 #887
Conversation
Hi @shuaich. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @dgrisonnet Could you please take a look at this PR? |
Remove elevated permissions from metrics-server
/ok-to-test /assign @serathius |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: serathius, shuaich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Remove elevated permissions from metrics-server
Testing
What this PR does / why we need it:
This PR cherry picks #884 from master branch.
With this PR, we are able to remove elevated permissions from metrics-server.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):None