-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Injecting TPU_NAME environment variable #209
Conversation
/skip |
/override pull-lws-test-e2e-main-1-27 see: https://kubernetes.slack.com/archives/C7J9RP96G/p1725908686722759 / https://kubernetes.slack.com/archives/C09QZ4DQB/p1725891002485159 |
er, that command has to be done by a github admin of this repo |
/override pull-lws-test-e2e-main-1-27 |
btw, we can do this today as follows: https://kubernetes.io/docs/tasks/inject-data-application/environment-variable-expose-pod-information/ |
maybe try closing and re-opening, that forces github to clear the statuses |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Edwinhr716, liurupeng The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
What type of PR is this?
/kind feature
What this PR does / why we need it
When requesting TPU resources, it injects the environment variable TPU_NAMES, which contains the name of the pod the TPU is in. This is needed as popular distributed runtime libraries such as Ray expect this variable to be set https://github.com/ray-project/ray/blob/ab27fe805c3fef4c8dc66bf5804f32cd522d1aad/python/ray/_private/accelerators/tpu.py#L247
Which issue(s) this PR fixes
Fixes #
Special notes for your reviewer
Does this PR introduce a user-facing change?