Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project refactor work #11

Merged
merged 5 commits into from
Mar 2, 2024
Merged

Project refactor work #11

merged 5 commits into from
Mar 2, 2024

Conversation

kerthcet
Copy link
Contributor

@kerthcet kerthcet commented Feb 29, 2024 •
edited
Loading

What I did with this PR:

  1. bump go version to v1.21 align with kubernetes
  2. Rename foler internal to pkg as kueue does
  3. Remove *.out and add a .gitignore file to this project.
  4. change repo name leader-worker-set to lws
  5. upgrade the controller-gen to v0.14.0 to fix test error and rerun make manifest.

fix #13
part of #8

@k8s-ci-robot k8s-ci-robot requested a review from ahg-g February 29, 2024 05:56
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 29, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 29, 2024
@kerthcet kerthcet changed the title Bump goversion to v1.21 align with kubernetes Project refactor work Feb 29, 2024
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 29, 2024
@jarias-lfx
Copy link

/easycla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 29, 2024
@kerthcet
Copy link
Contributor Author

kerthcet commented Mar 1, 2024

cc @ahg-g can we merge?

@ahg-g
Copy link
Contributor

ahg-g commented Mar 1, 2024

cc @ahg-g can we merge?

the test is failing, how did you verify that it passes? does it pass for you locally?

kerthcet added 2 commits March 1, 2024 11:27
@kerthcet
Add gitignore
cce1166 
Signed-off-by: kerthcet <[email protected]>
@kerthcet
Rename internal to pkg
139e152 
Signed-off-by: kerthcet <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 1, 2024
@kerthcet
Copy link
Contributor Author

kerthcet commented Mar 1, 2024

cc @ahg-g can we merge?

the test is failing, how did you verify that it passes? does it pass for you locally?

Yes, the test is always failing, I'm try to dig the reason, but I ran locally yesterday, the lws works as expected.

@kerthcet
Copy link
Contributor Author

kerthcet commented Mar 1, 2024

Let me fix the error first.

@kerthcet
Copy link
Contributor Author

kerthcet commented Mar 1, 2024

/test pull-lws-test-main

@kerthcet
Copy link
Contributor Author

kerthcet commented Mar 1, 2024

/test pull-lws-test-main

@kerthcet kerthcet force-pushed the bump-go-version branch 4 times, most recently from 079f2bc to 9d8cea1 Compare March 1, 2024 07:34
@kerthcet
Copy link
Contributor Author

kerthcet commented Mar 1, 2024 •
edited
Loading

Test error is not related to the controller logic. Add a flag -h to controller-gen solved this, have no idea why this happens, tracking here kubernetes-sigs/controller-tools#888. cc @ahg-g

The disadvantage is we'll see help info when run make manifest, better than test error. If anyone has any solutions, plz let me know, thanks.

I ran with this fix locally, everything behaves well with samples.

NAME                                                   READY   STATUS    RESTARTS   AGE
leader-worker-set-controller-manager-6858c77fd-65qt2   2/2     Running   0          108m
leaderworkerset-sample-0                               1/1     Running   0          74m
leaderworkerset-sample-1                               1/1     Running   0          74m
leaderworkerset-sample-2                               1/1     Running   0          74m

@kerthcet kerthcet mentioned this pull request Mar 1, 2024
Closed
@kerthcet kerthcet force-pushed the bump-go-version branch 2 times, most recently from b067dd6 to 291779f Compare March 1, 2024 09:30
ahg-g
ahg-g reviewed Mar 1, 2024
View reviewed changes
Makefile Outdated
crd:generateEmbeddedObjectMeta=true output:crd:artifacts:config=config/crd/bases\
webhook output:webhook:artifacts:config=config/webhook\
paths="./..."
$(CONTROLLER_GEN) -h \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this the help flag? which means it will actually not generate anything?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the issue is that the project is using v0.13.0, we should upgrade to v0.14.0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 167 below change CONTROLLER_TOOLS_VERSION ?= v0.13.0 to CONTROLLER_TOOLS_VERSION ?= v0.14.0

Copy link
Contributor Author

@kerthcet kerthcet Mar 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. seems working now. Thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the changelog, https://github.com/kubernetes-sigs/controller-tools/releases, didn't see any related changes. how do you find that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I compared it with jobset

@kerthcet kerthcet force-pushed the bump-go-version branch 2 times, most recently from 16a8c08 to 0ae51d5 Compare March 2, 2024 03:41
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 2, 2024
@ahg-g
Copy link
Contributor

ahg-g commented Mar 2, 2024

/lgtm
/approve

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 2, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, kerthcet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2024
@ahg-g
Copy link
Contributor

ahg-g commented Mar 2, 2024

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Mar 2, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0a4c0d6 into kubernetes-sigs:main Mar 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahg-g ahg-g ahg-g left review comments

Assignees

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make generate error as fatal: Invalid path
4 participants
@kerthcet @jarias-lfx @ahg-g @k8s-ci-robot