Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use controller revision to manage rolling updates #239

Open
3 tasks
liurupeng opened this issue Oct 24, 2024 · 4 comments · May be fixed by #277
Open
3 tasks

Use controller revision to manage rolling updates #239

liurupeng opened this issue Oct 24, 2024 · 4 comments · May be fixed by #277
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@liurupeng
Copy link
Collaborator

liurupeng commented Oct 24, 2024

What would you like to be added:
Use controller revision to store the leader/worker template; Support restarting the not updated replicas during rolling update

Why is this needed:

Completion requirements:

This enhancement requires the following artifacts:

  • Design doc
  • API change
  • Docs update

The artifacts should be linked in subsequent comments.

@liurupeng liurupeng added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 24, 2024
@liurupeng
Copy link
Collaborator Author

/assign

@liurupeng
Copy link
Collaborator Author

liurupeng commented Oct 24, 2024

same as #238

@ahg-g ahg-g changed the title Use controller revision to support rollback and restart during rolling update Use controller revision to manage rolling updates Dec 16, 2024
@ahg-g
Copy link
Contributor

ahg-g commented Dec 16, 2024

Using controller revision will allow us to avoid using template hashes to detect changes. Using template hashes to detect updates is not reliable across lws controller upgrades.

This will address:

@ahg-g
Copy link
Contributor

ahg-g commented Dec 16, 2024

/assign @Edwinhr716

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants