Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replicas restart during rolling upgrade will not use the original worker pod spec #238

Closed
liurupeng opened this issue Oct 23, 2024 · 2 comments · May be fixed by #277
Closed

Replicas restart during rolling upgrade will not use the original worker pod spec #238

liurupeng opened this issue Oct 23, 2024 · 2 comments · May be fixed by #277
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@liurupeng
Copy link
Collaborator

What happened:
When lws is in rolling update, any replicas that are not updated yet, but restarted due to failure handling, the worker statefulset will be recreated with updated lws worker template. The expected behavior should be recreated with the previous worker template
What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • Kubernetes version (use kubectl version):
  • LWS version (use git describe --tags --dirty --always):
  • Cloud provider or hardware configuration:
  • OS (e.g: cat /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@liurupeng liurupeng added the kind/bug Categorizes issue or PR as related to a bug. label Oct 23, 2024
@Edwinhr716
Copy link
Contributor

/assign @Edwinhr716

@ahg-g
Copy link
Contributor

ahg-g commented Dec 16, 2024

The solution is #239

@ahg-g ahg-g closed this as completed Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants