Add more git url regression coverage #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: monopole The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
monopole
requested review from
Liujingfang1
and removed request for
justinsb and
droot
k8s-ci-robot
added
approved
Liujingfang1
reviewed
Feb 7, 2019
pkg/git/repospec_test.go
Outdated
| { | ||
| input: "[email protected]:company/project.git//path?ref=branch", | ||
| repo: "[email protected]:company/project.git", | ||
| path: "//path", |
There was a problem hiding this comment.
Should it be path instead of //path?
There was a problem hiding this comment.
//path is the right value here, but it's not easy to see that.
Changed the test to check AbsPath(), a public method and more relevant to what actually happens.
k8s-ci-robot
added
size/M
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This particular URL mentioned in #750