Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove SecretGenerators from Kustomization.yaml #694

Closed
wants to merge 4 commits into from
Closed

remove SecretGenerators from Kustomization.yaml #694

wants to merge 4 commits into from
+18 −674

Conversation

Liujingfang1
Copy link
Contributor

Fix #692

remove SecretGenerator from kustomization.yaml
update unit tests

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Liujingfang1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 11, 2019
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 11, 2019
@Liujingfang1 Liujingfang1 requested review from monopole and liggitt and removed request for droot and grodrigues3 January 11, 2019 23:53
liggitt
liggitt reviewed Jan 12, 2019
View reviewed changes
Copy link
Contributor

@liggitt liggitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there in-repo docs/examples that need updating as well?

pkg/types/kustomization.go
// The resulting resource is a normal operand, subject to
// name prefixing, patching, etc. By default, the name of
// the map will have a suffix hash generated from its contents.
SecretGenerator []SecretArgs `json:"secretGenerator,omitempty" yaml:"secretGenerator,omitempty"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we drop the unused SecretArgs, CommandSources, Timeout, Shell, etc, fields?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should drop them. I'll update the change as well as dropping secretGenerator from the docs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated doc and removed secretArgs.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 14, 2019
liggitt
liggitt reviewed Jan 14, 2019
View reviewed changes
Copy link
Contributor

@liggitt liggitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit, lgtm otherwise

docs/kustomization.yaml
type: Opaque

# generatorOptions modify behavior of all ConfigMap and Secret generators
# generatorOptions modify behavior of all ConfigMap generators
generatorOptions:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop shell/timeoutSeconds examples?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@monopole
Copy link
Contributor

There's some pushback at #692, and that's just folks actively monitoring issues.

@liggitt Do you have any security concerns about keeping secret generator but making it work like configmap generator?

@liggitt
Copy link
Contributor

liggitt commented Jan 15, 2019

@liggitt Do you have any security concerns about keeping secret generator but making it work like configmap generator?

no, that seems reasonable as well

@Liujingfang1
Copy link
Contributor Author

@monopole Are we going to replace commands by files or literals as in configmap generator?

@Liujingfang1 Liujingfang1 mentioned this pull request Jan 16, 2019
Closed
@Liujingfang1
Copy link
Contributor Author

Close this PR since we chose a different approach as in #703

@Liujingfang1 Liujingfang1 deleted the removeSecretG branch April 4, 2019 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt

@pwittrock pwittrock

@monopole monopole

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Liujingfang1 @k8s-ci-robot @monopole @liggitt