Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add deprecation comment to commonLabels #5699

Conversation

stormqueen1990
Copy link
Member

commonLabels is deprecated, but the field did not have a deprecation comment, like other fields do. Add the deprecation comment, as some IDEs use that as a guideline to show a strikethrough in the field names (and to follow the pattern of other deprecated fields).

/kind documentation

`commonLabels` is deprecated, but the field did not have a deprecation comment,
like other fields do. Add the deprecation comment, as some IDEs use that as a
guideline to show a strikethrough in the field names (and to follow the pattern
of other deprecated fields).
@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 20, 2024
@koba1t
Copy link
Member

koba1t commented May 27, 2024

I think the commonLabels is already deprecated with the PR below.
#5464

Thanks @stormqueen1990
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 27, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: koba1t, stormqueen1990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2024
@koba1t
Copy link
Member

koba1t commented May 27, 2024

@k8s-ci-robot k8s-ci-robot merged commit cb432b0 into kubernetes-sigs:master May 27, 2024
10 checks passed
@stormqueen1990 stormqueen1990 deleted the chore/deprecation-common-labels branch May 29, 2024 00:34
@stormqueen1990
Copy link
Member Author

Hi @stormqueen1990 Could you add a deprecated message for web docs? https://github.com/kubernetes-sigs/cli-experimental/blob/master/site/content/en/references/kustomize/kustomization/commonlabels/_index.md

Hi there, @koba1t! Sure thing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants