-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reinstate #4652 without url-related code #4779
Conversation
Remove code that changes remotes-loading code path, as mandated by kubernetes-sigs#4756
Hi @annasong20. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -27,7 +27,7 @@ type RepoSpec struct { | |||
// TODO(monopole): Drop raw, use processed fields instead. | |||
raw string | |||
|
|||
// Host, e.g. github.com | |||
// Host, e.g. https://github.com/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a host. Can it be renamed? Maybe SchemeHost
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to approve this suggestion in a followup PR (it's a very good idea). But I'd like to keep this PR so that it only reinstates the parts #4652 that we wanted to keep so that it is easier to check the diff here.
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: annasong20, natasha41575 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Remove code that changes remotes-loading code path, as mandated by #4756