Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move demandDirectoryRoot into kyaml/filesys #4677

Merged
merged 6 commits into from
Jun 30, 2022
Merged

Move demandDirectoryRoot into kyaml/filesys #4677

merged 6 commits into from
Jun 30, 2022

Conversation

annasong20
Copy link
Contributor

In response to #4652 (comment)

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 14, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @annasong20. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 14, 2022
@natasha41575
Copy link
Contributor

natasha41575 commented Jun 14, 2022 •
edited
Loading

For the failed Windows tests, you have two options:

  1. Try to write the tests in an OS-agnostic way
  2. Create two different test files, one that has // +build !windows and one that has // +build windows and put the OS-specific tests in each

Option 1 is preferred but not necessary.

@natasha41575
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 14, 2022
@k8s-ci-robot
Copy link
Contributor

@annasong20: This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 18, 2022
@annasong20
Copy link
Contributor Author

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jun 18, 2022
@annasong20
Make root directory platform-agnostic
3967eaa 
Support windows root directory. Dogfood own error package.
@annasong20 annasong20 marked this pull request as ready for review June 20, 2022 21:44
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jun 20, 2022
@k8s-ci-robot k8s-ci-robot requested a review from yuwenma June 20, 2022 22:37
natasha41575
natasha41575 reviewed Jun 21, 2022
View reviewed changes
Copy link
Contributor

@natasha41575 natasha41575 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great! Some nits. Thanks for the thorough tests and trying to improve the code quality, this code isn't very easy to work with so it's great to see it improving.

api/loader/errors.go Outdated Show resolved Hide resolved
api/loader/fileloader_test.go Show resolved Hide resolved
kyaml/filesys/errors.go Outdated Show resolved Hide resolved
kyaml/filesys/filesystem.go Outdated Show resolved Hide resolved
kyaml/filesys/filesystem.go Outdated Show resolved Hide resolved
kyaml/filesys/filesystem_test.go Outdated Show resolved Hide resolved
kyaml/filesys/filesystem_test.go Show resolved Hide resolved
kyaml/filesys/filesystem_test.go Outdated Show resolved Hide resolved
@annasong20 annasong20 mentioned this pull request Jun 21, 2022
Merged
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 23, 2022
natasha41575
natasha41575 reviewed Jun 23, 2022
View reviewed changes
kyaml/filesys/fsondisk_test_unix.go Outdated Show resolved Hide resolved
kyaml/filesys/fsondisk_test_unix.go Outdated Show resolved Hide resolved
kyaml/filesys/fsondisk_test_windows.go Show resolved Hide resolved
natasha41575
natasha41575 reviewed Jun 28, 2022
View reviewed changes
api/go.sum Show resolved Hide resolved
kyaml/filesys/filesystem_test.go Outdated Show resolved Hide resolved
kyaml/filesys/filesystem_test.go Outdated Show resolved Hide resolved
kyaml/filesys/fsondisk_test.go Outdated Show resolved Hide resolved
kyaml/filesys/fsondisk_test.go Show resolved Hide resolved
kyaml/filesys/fsondisk_test.go Outdated Show resolved Hide resolved
kyaml/filesys/fsondisk_test_unix.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 29, 2022
@natasha41575
Copy link
Contributor

/lgtm

Will approve once CI passes

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 30, 2022
@natasha41575
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 30, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: annasong20, natasha41575

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2022
@k8s-ci-robot k8s-ci-robot merged commit d1102fb into kubernetes-sigs:master Jun 30, 2022
@annasong20 annasong20 deleted the move-demanddir branch June 30, 2022 18:15
@annasong20 annasong20 mentioned this pull request Sep 28, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natasha41575 natasha41575 natasha41575 left review comments

@mortent mortent Awaiting requested review from mortent

@yuwenma yuwenma Awaiting requested review from yuwenma

Assignees

@natasha41575 natasha41575

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@annasong20 @k8s-ci-robot @natasha41575