collect origin data only when the option is set #4332
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: natasha41575 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
| @@ -113,7 +113,11 @@ func (kt *KustTarget) MakeCustomizedResMap() (resmap.ResMap, error) { | |||
| } | |||
|
|
|||
| func (kt *KustTarget) makeCustomizedResMap() (resmap.ResMap, error) { | |||
| ra, err := kt.AccumulateTarget(&resource.Origin{}) | |||
| var origin *resource.Origin | |||
There was a problem hiding this comment.
nit: suggest using const var.
There was a problem hiding this comment.
The origin var changes as the resources are accumulated; the path and repo information get appended as we follow the kustomization tree, so I'm not sure how this can be a const
There was a problem hiding this comment.
weird, the comment is for "OriginAnnotations".
There was a problem hiding this comment.
Oh I see, I thought you meant for var origin. Anyways I changed OriginAnnotations to be const too. Thanks for the reviews!
natasha41575
force-pushed
the
OriginCollection
branch
from
40f4a1e to
7f77199
Compare
natasha41575
force-pushed
the
OriginCollection
branch
from
7f77199 to
a8f58b4
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
This PR is inspired by but does not implement the transformer annotations proposal.
In the previous implementation, the origin data is collected regardless of the input and added as an annotation if the option is set. This PR makes it so that we only collect the origin data if the option is set, among other small improvements.
/cc @yuwenma @KnVerey