Speed up custom parsing #3715
Merged
Speed up custom parsing #3715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: natasha41575 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XXL
natasha41575
force-pushed
the
SpeedUpCustomParsing
branch
from
410161d to
c3ea1bc
Compare
natasha41575
force-pushed
the
SpeedUpCustomParsing
branch
from
c3ea1bc to
2fbb0b8
Compare
monopole
reviewed
Mar 15, 2021
monopole
reviewed
Mar 15, 2021
natasha41575
force-pushed
the
SpeedUpCustomParsing
branch
from
2fbb0b8 to
2f6a611
Compare
|
/lgtm thanks! |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reference to #2825
Though you can now specify your own custom schema, doing so is pretty slow. Turns out this was because it was parsing it multiple times. This PR changes it to parse only once.
Also trimmed down the custom schema stored in krusty to the minimum necessary schema for the test cases, and added an example to the examples directory of how to use the new openapi field.