Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build up a suite of tests for remote URLs #4588

Closed
natasha41575 opened this issue Apr 18, 2022 · 2 comments · Fixed by #4615
Closed

Build up a suite of tests for remote URLs #4588

natasha41575 opened this issue Apr 18, 2022 · 2 comments · Fixed by #4615
Assignees
@annasong20
Labels
kind/regression Categorizes issue or PR as related to a regression from a prior release. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@natasha41575
Copy link
Contributor

natasha41575 commented Apr 18, 2022 •
edited
Loading

We have had at least two regressions with remote URLs: #4559 and #4455. We need to have a better suite of tests with all currently supported URLs so that we can make changes to the remote URL handling code more confidently, without introducing new regressions.

All of the supported URL types are documented here: https://github.com/kubernetes-sigs/kustomize/blob/master/examples/remoteBuild.md

We should have tests similar to TestRemoteResource and TestRemoteResourceGitHTTP in https://github.com/kubernetes-sigs/kustomize/blob/9452a031ba3179cf0ebf47c8577f2b601d28410e/api/krusty/remoteload_test.go that test all the possible URL types that we support.

Until #4559 is resolved, the test for the URL type in that issue should demonstrate "broken" behavior and can be updated along with the PR that fixes it.

cc @annasong20
@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 18, 2022
@natasha41575
Copy link
Contributor Author

/kind regression
/triage accepted

@k8s-ci-robot k8s-ci-robot added kind/regression Categorizes issue or PR as related to a regression from a prior release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 18, 2022
@annasong20
Copy link
Contributor

/assign @annasong20

annasong20 added a commit to annasong20/kustomize that referenced this issue May 3, 2022
@annasong20
Add url tests
c0dc68d 
Write comprehensive suite of integration tests for remote resources, as specified by Issue kubernetes-sigs#4588
@natasha41575 natasha41575 mentioned this issue May 3, 2022
Merged
k8s-ci-robot added a commit that referenced this issue May 5, 2022
@k8s-ci-robot
Merge pull request #4615 from annasong20/add-remote-resource-tests
496a962 
Fix Issue #4588
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@annasong20 annasong20

Labels
kind/regression Categorizes issue or PR as related to a regression from a prior release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Issue #4588 annasong20/kustomize
3 participants
@natasha41575 @k8s-ci-robot @annasong20