Skip to content

Commit

Permalink
address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Liujingfang1 committed Apr 9, 2019
1 parent ba43ecb commit e5d730e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
5 changes: 1 addition & 4 deletions pkg/plugins/transformers.go
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,7 @@ func isExecAvailable(name string) bool {
if os.IsNotExist(err) {
return false
}
if f.Mode()&0111 != 0000 {
return true
}
return false
return f.Mode()&0111 != 0000
}

func loadAndConfigurePlugin(
Expand Down
2 changes: 1 addition & 1 deletion pkg/target/generatorplugin_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ type: Opaque

func TestConfigMapGenerator(t *testing.T) {
tc := NewTestEnvController(t).Set()
//defer tc.Reset()
defer tc.Reset()

tc.BuildExecPlugin(
"someteam.example.com", "v1", "ConfigMapGenerator")
Expand Down

0 comments on commit e5d730e

Please sign in to comment.