Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should wsk action invoke be blocking by default? #419

Closed
rabbah opened this issue Feb 8, 2019 · 4 comments
Closed

should wsk action invoke be blocking by default? #419

rabbah opened this issue Feb 8, 2019 · 4 comments

Comments

@rabbah
Copy link

rabbah commented Feb 8, 2019 •
edited
Loading

invoke used to be a synchronous operation in the shell - but now is async matching the CLI... was this changed for parity with the CLI?

related: apache/openwhisk-cli#406
@starpit
Copy link
Contributor

starpit commented Feb 9, 2019

this should still be the case; i see your desired behavior, and we do have tests for this. hmm...

@rabbah
Copy link
Author

rabbah commented Feb 12, 2019 •
edited
Loading

I can't reproduce this after updating to master and rebuilding. If I do I'll reopen.

@rabbah rabbah closed this as completed Feb 12, 2019
@rabbah
Copy link
Author

rabbah commented Feb 15, 2019

I'm re-opening because while I can't reproduce it deterministically, I encounter this from time to time. Starting with a new shell in private browser, built off master, and webpacked, an invoke sends a request to the controller without ?blocking=true. I even observed once that after one such instance the very next request has ?blocking=true leaving me really puzzled.

@rabbah rabbah reopened this Feb 15, 2019
starpit added a commit to starpit/kui that referenced this issue Feb 16, 2019
@starpit
fix(plugin-openwhisk): openwhisk action invoke not always blocking
db44562 
Fixes kubernetes-sigs#419
@starpit starpit mentioned this issue Feb 16, 2019
Merged
starpit added a commit that referenced this issue Feb 16, 2019
@starpit
fix(plugin-openwhisk): openwhisk action invoke not always blocking
865cb4e 
Fixes #419
@rabbah
Copy link
Author

rabbah commented Feb 16, 2019

Thanks for tracking this down!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@starpit @rabbah