add flux operator python sdk example #962
Conversation
k8s-ci-robot
added
release-note-none
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @vsoch. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/L
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
Yeah agree it should be in one place - it was the same for the first example added (already duplicated). I think they are important in both places, so my plan is to get all three in (in this manner) and then update the site to have some javascript that will retrieve the file dynamically. It's how the examples / files are rendered here: https://converged-computing.github.io/flux-go/#pancakes-examples so hopefully I can figure out the same with hugo (I assume I can put html in markdown?) |
|
/assign @moficodes |
vsoch
force-pushed
the
docs/add-python-flux-operator-example
branch
from
8265dd1 to
aea166b
Compare
|
let's merge #969 first |
Nice!! Thank you @moficodes for adding that, I totally love it. |
|
@vsoch The include shortcode PR got merged. Could you rebase your PR and use include shortcode for the samples. |
k8s-ci-robot
added
the
needs-rebase
|
I'll update this one after #967 is merged to make rebasing simpler (only done once!) |
Signed-off-by: vsoch <[email protected]>
vsoch
force-pushed
the
docs/add-python-flux-operator-example
branch
from
aea166b to
e655fad
Compare
k8s-ci-robot
removed
the
needs-rebase
|
okay we are rebased! |
Signed-off-by: vsoch <[email protected]>
vsoch
force-pushed
the
docs/add-python-flux-operator-example
branch
from
b9171d4 to
73fcbba
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, vsoch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
|
||
| def main(): | ||
| """ | ||
| Run an MPI job. This requires the MPI Operator to be installed. |
There was a problem hiding this comment.
Is this accurate? Shouldn't it say flux operator?
There was a problem hiding this comment.
yep that's a typo. I'll do a quick PR to fix.
There was a problem hiding this comment.
Wooo I got PR number 1000!! #1000 Do I get a special prize? 🍪
There was a problem hiding this comment.
hahaha nice! Uhm.... Here's a 🥇
There was a problem hiding this comment.
Can I eat that? 😆
Just kidding :) Thanks for the quick review! And overall for everything you do for these projects. <3
This will add a Python example for using Kueue with the Flux Operator! I have most of the MPI Operator done too, but ran into a bug with the ssh secret volume.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Users likely want to integrate Kueue into Python-based workflow tools, and examples are helpful for that!
Which issue(s) this PR fixes:
Issue has been closed, previous issue is:
Fixes #947
Special notes for your reviewer:
This worked so well! I'm excited to try this out in an actual workflow tool
Does this PR introduce a user-facing change?