Refactor: split out flavor assigment logic #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/cleanup
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/assign @ahg-g |
|
/cc |
alculquicondor
force-pushed
the
flavor-refactor
branch
from
2bdacc9 to
7caa84f
Compare
ahg-g
reviewed
Dec 1, 2022
| // ClusterQueuePreempt means that there is not enough min quota in the | ||
| // ClusterQueue, so we need to preempt other workloads in the ClusterQueue | ||
| // with lower priority. | ||
| ClusterQueuePreempt |
There was a problem hiding this comment.
lets add those later in the PR that uses them.
There was a problem hiding this comment.
Just left CohortFit for now.
| "sigs.k8s.io/kueue/pkg/workload" | ||
| ) | ||
|
|
||
| func TestAssignFlavors(t *testing.T) { |
There was a problem hiding this comment.
are the tests in this file mostly a copy?
There was a problem hiding this comment.
yes, they were moved from scheduler_test.go
Change-Id: I3cd13127c2fc92be836becffcd8a7e69d2c3a819
alculquicondor
force-pushed
the
flavor-refactor
branch
from
7caa84f to
478dda8
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Split the logic for flavor assignment into its own package.
This decoupling can lead to better unit testing and more maintainable extensions in each of the packages.
I also added an "assignment mode" into the flavor assignment, which opens the possibility to assign flavors that require preemption.
Which issue(s) this PR fixes:
Preparation for #83
Special notes for your reviewer:
The integration tests didn't require any changes :D