Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kueue-viz: Dashboard for kueue: Initial commit #3727

Merged
merged 6 commits into from
Dec 5, 2024
Merged

kueue-viz: Dashboard for kueue: Initial commit #3727

merged 6 commits into from
Dec 5, 2024

Conversation

akram
Copy link
Contributor

@akram akram commented Dec 3, 2024 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #940

Special notes for your reviewer:

This is the first shot of the kueue-viz , the first kueue dashboard. This has been following the presentation of https://github.com/akram/kueue-viz and it contains the porting of the backend from python to golang.

Does this PR introduce a user-facing change?

kueue-viz: A Dashboard for kueue

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Dec 3, 2024
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Dec 3, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 3, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @akram!

It looks like this is your first PR to kubernetes-sigs/kueue 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kueue has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 3, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @akram. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 3, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 3, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit bcaef66
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/675174b081041100088a2e3b

@mbobrovskyi
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 3, 2024
mbobrovskyi
mbobrovskyi reviewed Dec 3, 2024
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 3, 2024
@akram akram force-pushed the adding-dashboard branch 4 times, most recently from 2653fe4 to 3c0e495 Compare December 3, 2024 19:19
akram added 3 commits December 4, 2024 22:08
@akram
kueue-viz: Dashboard for kueue: Initial commit
dc2f8b3
@akram
Various fixes after review:
3a70689 
- add differenciated gitignore
- add nul and emptyness checks in frontend
- remove util.go
- document GVR uniformly
- use GVR when forgotten
- remove unused code
@akram
Display informative message when no Items are found
4205f37
@akram
Various fixes after 2nd review:
d86e34b 
- Adding README.md instructions on how to run on kind
- Removing OpenShift instructions
- Cleaning env files
- Adding Copyright header in .js and .go files
- Aligning image builders and golang versions
@akram
Various fixes after 3rd review:
6d35640 
- Simply handlers by removing unused parameters
- Adjust copyright header newline
- Remove occurence of `oc` in README
- Remove incorrect description fields in yaml examples
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Dec 5, 2024
@mimowo
Copy link
Contributor

mimowo commented Dec 5, 2024

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons.

I synced with @akram on slack - he will apply for kubernetes-sigs membership and we will gradually increase his ownership according to the guidelines https://github.com/kubernetes/community/blob/master/community-membership.md.

In the meanwhile I will take care of approving the incoming PRs. For reviews, I would prefer engagement from the Kueue reviewers (among others @mbobrovskyi @PBundyra ). I'm looking forward to the collab!

@akram akram mentioned this pull request Dec 5, 2024
Closed
11 tasks
@akram
Various fixes after 4th review:
bcaef66 
- Add `CompilerDaemon` installation instruction
- Add `install` target in `frontend`'s `Makefile`
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Dec 5, 2024
mbobrovskyi
mbobrovskyi reviewed Dec 5, 2024
View reviewed changes
Copy link
Contributor

@mbobrovskyi mbobrovskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks! This is an awesome feature!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d09893cee8b3c1decd26922cd17ac5d3802dab0b

@mimowo
Copy link
Contributor

mimowo commented Dec 5, 2024 •
edited
Loading

/approve
@akram please follow up with the next productization steps:

  • I think it would be good to publish the image
  • move it out of the cmd/experimental
  • align the release process with the main Kueue
    (possibly more)
  • reference the project from the kueue main documentation page (https://kueue.sigs.k8s.io/), for starter we can do similar as for kueuectl plugin, but later it deserves more advertisement I think
  • e2e tests for the dashboard backend and frontend

I think kueuectl could serve as a great example (and other projects like importer). Also, please summarize what is yet missing for MVP in terms of features (if anything)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akram, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0af8d0c into kubernetes-sigs:main Dec 5, 2024
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.10 milestone Dec 5, 2024
@mimowo mimowo mentioned this pull request Dec 5, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimowo mimowo mimowo left review comments

@mbobrovskyi mbobrovskyi mbobrovskyi left review comments

@denkensk denkensk Awaiting requested review from denkensk

@tenzen-y tenzen-y Awaiting requested review from tenzen-y

Assignees

@mbobrovskyi mbobrovskyi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v0.10
Development

Successfully merging this pull request may close these issues.

Dashboard support in Kueue
4 participants
@akram @k8s-ci-robot @mbobrovskyi @mimowo