Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TAS: support rank-ordering for Kubeflow #3604

Merged
merged 5 commits into from
Nov 21, 2024
Merged

TAS: support rank-ordering for Kubeflow #3604

merged 5 commits into from
Nov 21, 2024

Conversation

mbobrovskyi
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

TAS: support rank-ordering for Kubeflow

Which issue(s) this PR fixes:

Part of #3450
Part of #3533

Special notes for your reviewer:

Does this PR introduce a user-facing change?

TAS: support rank-based ordering for Kubeflow

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 20, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 20, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 20, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 777101d
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/673f4bd0df06c100083e35a4

@mbobrovskyi mbobrovskyi marked this pull request as draft November 20, 2024 18:04
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 20, 2024
@mbobrovskyi
Copy link
Contributor Author

/test all

@mbobrovskyi mbobrovskyi force-pushed the feature/support-rank-ordering-for-kubeflow branch from 50d7977 to e974dc3 Compare November 21, 2024 07:07
mimowo
mimowo reviewed Nov 21, 2024
View reviewed changes
mimowo
mimowo reviewed Nov 21, 2024
View reviewed changes
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, I would just suggest to separate the preparatory work to separate PR

@mbobrovskyi mbobrovskyi force-pushed the feature/support-rank-ordering-for-kubeflow branch from e974dc3 to f6d72b4 Compare November 21, 2024 07:47
@k8s-ci-robot k8s-ci-robot removed the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 21, 2024
@mbobrovskyi
Copy link
Contributor Author

/test all

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 21, 2024
@mbobrovskyi mbobrovskyi force-pushed the feature/support-rank-ordering-for-kubeflow branch from a8cb61d to 94dd5dd Compare November 21, 2024 09:13
@mbobrovskyi mbobrovskyi marked this pull request as ready for review November 21, 2024 09:32
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 21, 2024
@mbobrovskyi mbobrovskyi mentioned this pull request Nov 21, 2024
Merged
@mbobrovskyi
Copy link
Contributor Author

/hold for #3606.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 21, 2024
@mbobrovskyi mbobrovskyi force-pushed the feature/support-rank-ordering-for-kubeflow branch from 94dd5dd to fc0f389 Compare November 21, 2024 11:44
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 21, 2024
@mbobrovskyi mbobrovskyi force-pushed the feature/support-rank-ordering-for-kubeflow branch from fc0f389 to a4d7805 Compare November 21, 2024 11:45
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 21, 2024
@mbobrovskyi
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 21, 2024
@mbobrovskyi mbobrovskyi force-pushed the feature/support-rank-ordering-for-kubeflow branch from a06bab5 to 777101d Compare November 21, 2024 15:03
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 21, 2024
mimowo
mimowo reviewed Nov 21, 2024
View reviewed changes
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
Awesome!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e80d33ee71f81c42e9391167091a0c7dad636f63

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbobrovskyi, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2024
@k8s-ci-robot k8s-ci-robot merged commit 4bbddce into kubernetes-sigs:main Nov 21, 2024
17 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.10 milestone Nov 21, 2024
@mbobrovskyi mbobrovskyi deleted the feature/support-rank-ordering-for-kubeflow branch November 21, 2024 15:33
kannon92 pushed a commit to openshift-kannon92/kubernetes-sigs-kueue that referenced this pull request Dec 5, 2024
@mbobrovskyi @kannon92
TAS: support rank-ordering for Kubeflow (kubernetes-sigs#3604)
0e74cd2 
* TAS: support rank-ordering for Kubeflow.

* Add ExpectLocalQueuesToBeActive.

* Add MPIJob e2e test.

* Add unit tests.

* Add PyTorchJob e2e test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimowo mimowo mimowo left review comments

@tenzen-y tenzen-y Awaiting requested review from tenzen-y

@PBundyra PBundyra Awaiting requested review from PBundyra

@trasc trasc Awaiting requested review from trasc

Assignees

@mimowo mimowo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v0.10
Development

Successfully merging this pull request may close these issues.
3 participants
@mbobrovskyi @k8s-ci-robot @mimowo