TAS: support rank-based ordering for JobSet #3591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
approved
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
k8s-ci-robot
added
the
size/L
mimowo
force-pushed
the
tas-rank-ordering-jobset
branch
from
0fadc0b to
4b83778
Compare
mimowo
force-pushed
the
tas-rank-ordering-jobset
branch
from
4b83778 to
094f72b
Compare
PBundyra
reviewed
Nov 19, 2024
| return nil, err | ||
| } | ||
| singleJobSize := podSetSize / rjInfo.replicasCount | ||
| if *podIndex >= singleJobSize { |
There was a problem hiding this comment.
Suggested change
| if *podIndex >= singleJobSize { | |
| if rank >= singleJobSize { |
There was a problem hiding this comment.
This would work, but isn't the podIndex better reflect the intention? The rank can still be mutated
mimowo
force-pushed
the
tas-rank-ordering-jobset
branch
from
094f72b to
8d43c08
Compare
k8s-ci-robot
added
size/XL
mimowo
force-pushed
the
tas-rank-ordering-jobset
branch
from
8d43c08 to
c999305
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mimowo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mimowo
force-pushed
the
tas-rank-ordering-jobset
branch
4 times, most recently
from
db98664 to
c0f69b6
Compare
mimowo
force-pushed
the
tas-rank-ordering-jobset
branch
from
c0f69b6 to
4419dcd
Compare
|
@PBundyra I have updated the e2e test and it is passing now, PTAL |
PBundyra
reviewed
Nov 19, 2024
PBundyra
reviewed
Nov 19, 2024
|
Thanks @mimowo! |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: d81f4f120d150073c4e02deab2fdea842489e076
|
Co-authored-by: Patryk Bundyra <[email protected]>
k8s-ci-robot
removed
the
lgtm
Co-authored-by: Patryk Bundyra <[email protected]>
|
FYI. I have ran this test locally in a loop around 20 times and all passed. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 64e0e458921be6133459b81c3d4d742dca00e8e6
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/test pull-kueue-test-multikueue-e2e-main |
kannon92
pushed a commit
to kannon92/kueue
that referenced
this pull request
Dec 5, 2024
* TAS: support rank-based ordering for JobSet * Update test/e2e/tas/jobset_test.go Co-authored-by: Patryk Bundyra <[email protected]> * Update test/e2e/tas/jobset_test.go Co-authored-by: Patryk Bundyra <[email protected]> --------- Co-authored-by: Patryk Bundyra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Part of #3450
Part of #3533
Special notes for your reviewer:
I don't have e2e test yet, but getting early feedback would be great.
Does this PR introduce a user-facing change?