Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TAS: Add documentation page for concepts #3432

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

mimowo
Copy link
Contributor

@mimowo mimowo commented Nov 4, 2024

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Part of #2724

Special notes for your reviewer:

I think it would also be useful to have a tasks page, but I'm unlikely to be able to write it before 0.9.0.

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 4, 2024
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2024
@mimowo
Copy link
Contributor Author

mimowo commented Nov 4, 2024

/assign @tenzen-y @PBundyra

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 4, 2024
Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 5cfa7ea
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6729bd9c24069f0009fe3921
😎 Deploy Preview https://deploy-preview-3432--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mimowo mimowo force-pushed the tas-documentation branch 2 times, most recently from ab8774f to 09771d1 Compare November 4, 2024 13:54
@mimowo mimowo force-pushed the tas-documentation branch from 09771d1 to 42dda3b Compare November 4, 2024 13:55
Copy link
Contributor

@dgrove-oss dgrove-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor suggestions.

@mimowo mimowo force-pushed the tas-documentation branch 4 times, most recently from 1fc7c2d to 4d4badc Compare November 4, 2024 15:09
@tenzen-y
Copy link
Member

tenzen-y commented Nov 4, 2024

/cc

@mimowo mimowo force-pushed the tas-documentation branch from 4d4badc to 6f45058 Compare November 5, 2024 06:26
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 379ad559adc515606ff2ffb03ea06d731145aeca

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Co-authored-by: David Grove <[email protected]>
Co-authored-by: Yuki Iwai <[email protected]>
@mimowo mimowo force-pushed the tas-documentation branch from 6f45058 to 5cfa7ea Compare November 5, 2024 06:39
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2024
@mimowo
Copy link
Contributor Author

mimowo commented Nov 5, 2024

a race condition :) I have yet pushed a bit more comprehensive overview of the capacity calculation in the last update. PTAL

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 185463a9ea946edc7ac2f4cabbe84d0e3f1b4ae3

@k8s-ci-robot k8s-ci-robot merged commit 7e0e3cb into kubernetes-sigs:main Nov 5, 2024
7 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.9 milestone Nov 5, 2024
kannon92 pushed a commit to kannon92/kueue that referenced this pull request Dec 5, 2024
* TAS: Add documentation page for concepts

* Review remarks

Co-authored-by: David Grove <[email protected]>
Co-authored-by: Yuki Iwai <[email protected]>

---------

Co-authored-by: David Grove <[email protected]>
Co-authored-by: Yuki Iwai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants