-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TAS: Add documentation page for concepts #3432
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ab8774f
to
09771d1
Compare
09771d1
to
42dda3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor suggestions.
1fc7c2d
to
4d4badc
Compare
/cc |
4d4badc
to
6f45058
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
/lgtm
/approve
LGTM label has been added. Git tree hash: 379ad559adc515606ff2ffb03ea06d731145aeca
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mimowo, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Co-authored-by: David Grove <[email protected]> Co-authored-by: Yuki Iwai <[email protected]>
6f45058
to
5cfa7ea
Compare
a race condition :) I have yet pushed a bit more comprehensive overview of the capacity calculation in the last update. PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
/lgtm
LGTM label has been added. Git tree hash: 185463a9ea946edc7ac2f4cabbe84d0e3f1b4ae3
|
* TAS: Add documentation page for concepts * Review remarks Co-authored-by: David Grove <[email protected]> Co-authored-by: Yuki Iwai <[email protected]> --------- Co-authored-by: David Grove <[email protected]> Co-authored-by: Yuki Iwai <[email protected]>
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Which issue(s) this PR fixes:
Part of #2724
Special notes for your reviewer:
I think it would also be useful to have a tasks page, but I'm unlikely to be able to write it before 0.9.0.
Does this PR introduce a user-facing change?