Exclude non-ready nodes from scheduling. #3413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
|
/assign @mimowo |
|
I am on the integration tests failure |
mszadkow
force-pushed
the
feature/tas-exclude-non-ready
branch
from
bfdf1f8 to
275a18a
Compare
|
/retest |
1 similar comment
|
/retest |
mbobrovskyi
suggested changes
Nov 3, 2024
tenzen-y
reviewed
Nov 4, 2024
mszadkow
force-pushed
the
feature/tas-exclude-non-ready
branch
from
d230cc6 to
b1ef2cc
Compare
|
/retest |
mszadkow
force-pushed
the
feature/tas-exclude-non-ready
branch
from
b1ef2cc to
dc4e2ef
Compare
|
/lgtm Thanks! |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 87f227e692d7b95f36db54f6c27aea0f5bea86c1
|
mimowo
reviewed
Nov 4, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mimowo, mszadkow The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
kannon92
pushed a commit
to kannon92/kueue
that referenced
this pull request
Dec 5, 2024
* Exclude non-ready nodes from scheduling. * Update after code review * Move TAS indexer to subpackage * Use TAS indexer to filter out non ready nodes * Update integration tests * Update to match verify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Non-ready nodes are excluded by kube-scheduler so including them in TAS can be considered a bug - they will not be able to use in practice, and the pods will not schedule.
Which issue(s) this PR fixes:
Fixes #3401
Special notes for your reviewer:
Does this PR introduce a user-facing change?