Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TAS: cleanups after merging main PRs #3291

Merged
merged 1 commit into from
Oct 23, 2024
Merged

TAS: cleanups after merging main PRs #3291

merged 1 commit into from
Oct 23, 2024

Conversation

mimowo
Copy link
Contributor

@mimowo mimowo commented Oct 23, 2024 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

To address non-blocking review remarks for the main PRs:

Which issue(s) this PR fixes:

Part of #2724

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Oct 23, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 23, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 23, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 997c7a0
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6718e324330998000827103d

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 23, 2024
@mimowo mimowo force-pushed the tas-small-follow-ups branch from 28ac60e to a22958b Compare October 23, 2024 07:37
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 23, 2024
@mimowo mimowo force-pushed the tas-small-follow-ups branch from a22958b to 7d39287 Compare October 23, 2024 07:54
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 23, 2024
@mimowo mimowo force-pushed the tas-small-follow-ups branch from 7d39287 to b02e4af Compare October 23, 2024 07:55
This was referenced Oct 23, 2024
Merged
Merged
@mimowo mimowo force-pushed the tas-small-follow-ups branch from b02e4af to 6d7bb60 Compare October 23, 2024 08:13
@mimowo
Copy link
Contributor Author

mimowo commented Oct 23, 2024

/assign @PBundyra
/cc @tenzen-y

@k8s-ci-robot k8s-ci-robot requested a review from tenzen-y October 23, 2024 08:14
tenzen-y
tenzen-y reviewed Oct 23, 2024
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
/lgtm
/approve
/hold for @PBundyra

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: df21f413c2f223af4487bd328e1e700031fc79bb

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@PBundyra
Copy link
Contributor

LGTM, I will hold until the final changes to tests are made

@mimowo mimowo force-pushed the tas-small-follow-ups branch from 6d7bb60 to 23434a6 Compare October 23, 2024 11:41
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2024
@mimowo mimowo force-pushed the tas-small-follow-ups branch from 23434a6 to 997c7a0 Compare October 23, 2024 11:50
@mimowo
Copy link
Contributor Author

mimowo commented Oct 23, 2024

LGTM, I will hold until the final changes to tests are made

should be done now, PTAL

@PBundyra
Copy link
Contributor

Thank you!
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2024
@PBundyra
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 206f7d34cb0ca92e9147d314f7d41c598ee15062

@k8s-ci-robot k8s-ci-robot merged commit 8ac148c into kubernetes-sigs:main Oct 23, 2024
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.9 milestone Oct 23, 2024
PBundyra pushed a commit to PBundyra/kueue that referenced this pull request Nov 5, 2024
@mimowo @PBundyra
TAS: cleanups after merging main PRs (kubernetes-sigs#3291)
34e8824
kannon92 pushed a commit to openshift-kannon92/kubernetes-sigs-kueue that referenced this pull request Nov 19, 2024
@mimowo @kannon92
TAS: cleanups after merging main PRs (kubernetes-sigs#3291)
c8b89bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@denkensk denkensk Awaiting requested review from denkensk

@PBundyra PBundyra Awaiting requested review from PBundyra

@tenzen-y tenzen-y Awaiting requested review from tenzen-y

Assignees

@tenzen-y tenzen-y

@PBundyra PBundyra

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.9
Development

Successfully merging this pull request may close these issues.
4 participants
@mimowo @k8s-ci-robot @PBundyra @tenzen-y