TAS: Add scheduling gate to Pods admitted by TAS #3262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mimowo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/L
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
|
/cc @alculquicondor |
mimowo
changed the title
mimowo
changed the title
mimowo
changed the title
mimowo
force-pushed
the
tas-add-scheduling-gate
branch
from
cc52566 to
a7caaf3
Compare
mimowo
force-pushed
the
tas-add-scheduling-gate
branch
from
a7caaf3 to
f783af8
Compare
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 8bebf311fa94a3ee3c153261646000eea6d1148b
|
tenzen-y
reviewed
Oct 18, 2024
| @@ -118,6 +127,12 @@ func (podSetInfo *PodSetInfo) Merge(o PodSetInfo) error { | |||
| podSetInfo.Tolerations = append(podSetInfo.Tolerations, t) | |||
| } | |||
| } | |||
| // make sure we don't duplicate schedulingGates | |||
| for _, t := range o.SchedulingGates { | |||
| if slices.Index(podSetInfo.SchedulingGates, t) == -1 { | |||
There was a problem hiding this comment.
Could you switch from this to HasGate lib?
Line 26 in 4c06305
| @@ -170,6 +187,10 @@ func RestorePodSpec(meta *metav1.ObjectMeta, spec *corev1.PodSpec, info PodSetIn | |||
| spec.Tolerations = slices.Clone(info.Tolerations) | |||
| changed = true | |||
| } | |||
| if !slices.Equal(spec.SchedulingGates, info.SchedulingGates) { | |||
There was a problem hiding this comment.
Do we need to respect the order of schedulingGate?
I'm wondering if we can ignore the order differences.
PBundyra
pushed a commit
to PBundyra/kueue
that referenced
this pull request
Nov 5, 2024
kannon92
pushed a commit
to openshift-kannon92/kubernetes-sigs-kueue
that referenced
this pull request
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
To add the scheduling pods to the PodTemplate (and thus the Pods) admitted by TAS.
Which issue(s) this PR fixes:
Part of #2724
Special notes for your reviewer:
No release note here, I will add it in a single PR which adds the API.
The assignment is done in PR #3256 . The gate will be removed in a follow up PR. This PR can be merged indepdendently of computing the assignment or topology ungater, but all 3 PRs are required for the feature to work e2e.
Does this PR introduce a user-facing change?