TAS: Introduce pod scheduling gate utils #3234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
approved
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
mimowo
changed the title
trasc
reviewed
Oct 15, 2024
mimowo
force-pushed
the
scheduling-gates-commons
branch
2 times, most recently
from
d87fa6c to
de19486
Compare
|
Overall LGTM, but leaving the label to @PBundyra if he wants to have a look. |
mimowo
force-pushed
the
scheduling-gates-commons
branch
from
de19486 to
180088b
Compare
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 2c07663facdf4cbf5cce728b5615ea5c2ce8d8f9
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mimowo, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM, thanks! |
k8s-ci-robot
removed
the
do-not-merge/hold
kannon92
pushed a commit
to openshift-kannon92/kubernetes-sigs-kueue
that referenced
this pull request
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
To expose the utils for pod scheduling gates so that the code can be reused between pod controller, and the new TopologyUngater.
Which issue(s) this PR fixes:
Part of #2724
Special notes for your reviewer:
The new utils are going to be used by TopologyUngater (for more details see the prototype #3218).
Does this PR introduce a user-facing change?