Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Go version to 1.23 #3225

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

tenzen-y
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Before we release the next minor version (v0.9), upgrading Go version would be better.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 14, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2024
@tenzen-y
Copy link
Member Author

/hold
for test-infra

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 14, 2024
Copy link

netlify bot commented Oct 14, 2024

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit a90c0e2
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/670cf31bf453b10008995491

@mbobrovskyi
Copy link
Contributor

mbobrovskyi commented Oct 14, 2024

Should we update minimal version to 1.23? Maybe it's enough to update to 1.22.7? WDYT?

@mbobrovskyi
Copy link
Contributor

Also we should update

ARG BUILDER_IMAGE=golang:1.22.6
and
- go version v1.22.6+
.

@tenzen-y
Copy link
Member Author

Should we update minimal version to 1.23? Maybe it's enough to update to 1.22.7? WDYT?

As I described, before new release, it should be great to upgrade to 1.23.
If we do not update it now, we lose the chance about 4 months since after releasing 0.9, we want to keep using the same Go version for the Kueue patch version.

@mbobrovskyi
Copy link
Contributor

As I described, before new release, it should be great to upgrade to 1.23.
If we do not update it now, we lose the chance about 4 months since after releasing 0.9, we want to keep using the same Go version for the Kueue patch version.

That's a good point. Thanks for the explanation.

@tenzen-y
Copy link
Member Author

Also we should update

ARG BUILDER_IMAGE=golang:1.22.6

and

- go version v1.22.6+

.

Good point. Let me see it.

@tenzen-y
Copy link
Member Author

Also we should update

ARG BUILDER_IMAGE=golang:1.22.6

and

- go version v1.22.6+

.

Good point. Let me see it.

Done.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 14, 2024
@tenzen-y
Copy link
Member Author

/retest

@mbobrovskyi
Copy link
Contributor

/lgtm

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6bf2f602065fab0a5da553c9877d08e008f58dfe

@tenzen-y
Copy link
Member Author

It seems that it takes a little time to synchronize the test-infra repository to the infra cluster.

@tenzen-y
Copy link
Member Author

/retest

@tenzen-y
Copy link
Member Author

Get ready 🚀
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2024
@k8s-ci-robot k8s-ci-robot merged commit 5b5ed28 into kubernetes-sigs:main Oct 14, 2024
17 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.9 milestone Oct 14, 2024
@tenzen-y tenzen-y deleted the upgrade-go-version branch October 14, 2024 20:24
kannon92 pushed a commit to openshift-kannon92/kubernetes-sigs-kueue that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants