-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Go version to 1.23 #3225
Upgrade Go version to 1.23 #3225
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
Should we update minimal version to 1.23? Maybe it's enough to update to 1.22.7? WDYT? |
Also we should update Line 1 in 0d73e6a
kueue/cmd/experimental/kjobctl/README.md Line 12 in 0d73e6a
|
As I described, before new release, it should be great to upgrade to 1.23. |
That's a good point. Thanks for the explanation. |
Good point. Let me see it. |
Signed-off-by: Yuki Iwai <[email protected]>
44043b9
to
a90c0e2
Compare
Done. |
/retest |
/lgtm Thanks! |
LGTM label has been added. Git tree hash: 6bf2f602065fab0a5da553c9877d08e008f58dfe
|
It seems that it takes a little time to synchronize the test-infra repository to the infra cluster. |
/retest |
Get ready 🚀 |
Signed-off-by: Yuki Iwai <[email protected]>
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Before we release the next minor version (v0.9), upgrading Go version would be better.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?