Default requests to limits in Workload #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/feature
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
if the requests are not set Change-Id: I9f59d9e87f48d51afc1c48082943cc3233a2fd1b
alculquicondor
force-pushed
the
requests
branch
from
1d4b168 to
3fd046a
Compare
kerthcet
reviewed
Aug 10, 2022
| func setContainersDefaults(containers []corev1.Container) { | ||
| for i := range containers { | ||
| c := &containers[i] | ||
| if c.Resources.Limits != nil { |
There was a problem hiding this comment.
Not related to this PR, we currently leverage the requests in resource quota, should we also consider the limits.
There was a problem hiding this comment.
Are you talking about kubernetes' ResourceQuotas? If so, I would imagine they run after defaults are applied, but I don't have expertise to know for sure.
There was a problem hiding this comment.
I mean the resources.Limits in podSpec.
There was a problem hiding this comment.
It was the intention that we only look at requests, similar to the NodeResources Filter plugin in kube-scheduler.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
kerthcet
added a commit
to kerthcet/kueue
that referenced
this pull request
Feb 27, 2023
In kubernetes-sigs#317, we will default workload resource requests to limits if requests not specified. But this will introduce a bug for in job controller reconciling, job will be judged as not equal to workload, so workload will be deleted and re-create indefinitely Signed-off-by: Kante Yin <[email protected]>
kerthcet
added a commit
to kerthcet/kueue
that referenced
this pull request
Mar 2, 2023
In kubernetes-sigs#317, we will default workload resource requests to limits if requests not specified. But this will introduce a bug for in job controller reconciling, job will be judged as not equal to workload, so workload will be deleted and re-create indefinitely Signed-off-by: Kante Yin <[email protected]>
kerthcet
added a commit
to kerthcet/kueue
that referenced
this pull request
Mar 2, 2023
In kubernetes-sigs#317, we will default workload resource requests to limits if requests not specified. But this will introduce a bug for in job controller reconciling, job will be judged as not equal to workload, so workload will be deleted and re-create indefinitely Signed-off-by: Kante Yin <[email protected]>
kerthcet
added a commit
to kerthcet/kueue
that referenced
this pull request
Mar 2, 2023
In kubernetes-sigs#317, we will default workload resource requests to limits if requests not specified. But this will introduce a bug for in job controller reconciling, job will be judged as not equal to workload, so workload will be deleted and re-create indefinitely Signed-off-by: Kante Yin <[email protected]>
kerthcet
added a commit
to kerthcet/kueue
that referenced
this pull request
Mar 9, 2023
In kubernetes-sigs#317, we will default workload resource requests to limits if requests not specified. But this will introduce a bug for in job controller reconciling, job will be judged as not equal to workload, so workload will be deleted and re-create indefinitely Signed-off-by: Kante Yin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Default requests to limits if requests are not set.
This matches the internal defaulting for k8s Pods.
Which issue(s) this PR fixes:
Fixes #316
Special notes for your reviewer: