Extend documentation on pod group support [pod groups] #1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
added
cncf-cla: yes
mimowo
force-pushed
the
pod-groups-docs
branch
from
cff3917 to
2f6fea0
Compare
mimowo
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/assign @tenzen-y @alculquicondor |
trasc
reviewed
Feb 5, 2024
|
lgtm |
tenzen-y
reviewed
Feb 7, 2024
Comment on lines
133
to
138
| Note that, this design choice impacts the scenario of | ||
| [preemption](/docs/concepts/cluster_queue/#preemption). | ||
| When a workload represented by the pod group is preempted all of its pods | ||
| are killed by Kueue (by delete requests). However, later, when the workload is | ||
| re-admitted, Kueue will not re-create the terminated pods. This task is left to | ||
| the user (or the external controller). |
PBundyra
reviewed
Feb 7, 2024
PBundyra
reviewed
Feb 7, 2024
PBundyra
reviewed
Feb 7, 2024
mimowo
force-pushed
the
pod-groups-docs
branch
6 times, most recently
from
466c735 to
eee3acf
Compare
k8s-ci-robot
added
size/L
mimowo
force-pushed
the
pod-groups-docs
branch
from
eee3acf to
4d0e5a6
Compare
Co-authored-by: Yuki Iwai <[email protected]> Co-authored-by: Patryk Bundyra <[email protected]>
mimowo
force-pushed
the
pod-groups-docs
branch
from
3cb5660 to
317ac6a
Compare
tenzen-y
reviewed
Feb 8, 2024
Comment on lines
142
to
143
| **NOTE:** We recommend using the kubernetes Job API or similar CRDs such as | ||
| JobSet, MPIJob, RayJob, etc. |
There was a problem hiding this comment.
Tied https://kueue.sigs.k8s.io/docs/tasks/#batch-user here would be better.
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, mimowo, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel Comments addressed, PTAL. |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 17e670abb3552cbea3c6a5e1c15d760489a2c931
|
kannon92
pushed a commit
to openshift-kannon92/kubernetes-sigs-kueue
that referenced
this pull request
Nov 19, 2024
…gs#1684) * Extend documentation on pod group support * Review remarks Co-authored-by: Yuki Iwai <[email protected]> Co-authored-by: Patryk Bundyra <[email protected]> * Align casing of pods and pod groups for consistency * review remarks * Fix indentation --------- Co-authored-by: Yuki Iwai <[email protected]> Co-authored-by: Patryk Bundyra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Which issue(s) this PR fixes:
Part of #976
Special notes for your reviewer:
Does this PR introduce a user-facing change?