-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix webhooks serving in non-leading replicas #1509
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @astefanutti. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astefanutti, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: e23921a337eb3fe88520ab4ac533c8a9758fadc7
|
/hold |
/cherry-pick release-0.5 |
@tenzen-y: once the present PR merges, I will cherry-pick it on top of release-0.5 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@tenzen-y I've successfully tested this patch with 2 replicas, and confirm webhooks are served in the non-leading replica, and also admission requests fail over the non-leading replica when deleting the leading one. |
It's great to hear :) Thanks for your cross-projects contributions! |
@tenzen-y: #1509 failed to apply on top of branch "release-0.5":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@tenzen-y do you want me to cherry-pick it manually? |
Yes, Please go ahead. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR upgrades cert-controller to v0.10.1 so it includes open-policy-agent/cert-controller#166.
Which issue(s) this PR fixes:
Fixes #1445
Special notes for your reviewer:
I've successfully tested webhooks are served in non-leading replicas, and admission requests fail over the other replicas when deleting the leading one.
Does this PR introduce a user-facing change?