-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] Reproduce missing the nodeSelector issue on the PyTorchJob #1422
[DO NOT MERGE] Reproduce missing the nodeSelector issue on the PyTorchJob #1422
Conversation
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
/hold |
d9cb9a7
to
54c45f1
Compare
This is still under implementing. |
Have you figured why the node selectors are getting dropped? |
I'm organizing the cause now. So I will create another PR. |
2b1ba5d
to
0e62f1a
Compare
Signed-off-by: tenzen-y <[email protected]>
0373371
to
30fcf25
Compare
Signed-off-by: tenzen-y <[email protected]>
@tenzen-y: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
I found that my reproducing steps were invalid. |
@tenzen-y: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR can show that #1407 is reproducable only on the E2E Test.
Here is a reproduced Job: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_kueue/1422/pull-kueue-test-e2e-main-1-27/1733124744468762624
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?