Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration test to show that Job continues when ProvisioningRequest is deleted #1359

Closed
mimowo opened this issue Nov 22, 2023 · 5 comments · Fixed by #1423
Closed

Add integration test to show that Job continues when ProvisioningRequest is deleted #1359

mimowo opened this issue Nov 22, 2023 · 5 comments · Fixed by #1423
Assignees
@B1F030
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@mimowo
Copy link
Contributor

mimowo commented Nov 22, 2023

We need to ensure this scenario is covered. It is experimentally verified to be the case, but we need to prevent regressions here.

The ProvisioningRequest can be deleted, and the job is able to run because Cluster Autoscaler does not collect nodes with bound pods.
@mimowo
Copy link
Contributor Author

mimowo commented Nov 22, 2023

cc @alculquicondor

@alculquicondor
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Nov 22, 2023
@alculquicondor
Copy link
Contributor

/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@alculquicondor:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Nov 22, 2023
@B1F030
Copy link
Member

B1F030 commented Nov 23, 2023 •
edited
Loading

/assign
I'm glad to help. Planning to do this after KEP-1224.

@B1F030 B1F030 mentioned this issue Dec 8, 2023
Merged
@B1F030 B1F030 mentioned this issue Feb 4, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@B1F030 B1F030

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add integration test for ProvisioningRequest B1F030/kueue
4 participants
@alculquicondor @mimowo @k8s-ci-robot @B1F030