Skip to content

Commit

Permalink
Review remarks
Browse files Browse the repository at this point in the history
  • Loading branch information
mimowo committed Oct 28, 2024
1 parent 8fef259 commit 17f5909
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions pkg/cache/clusterqueue.go
Original file line number Diff line number Diff line change
Expand Up @@ -419,8 +419,8 @@ func (c *clusterQueue) updateWithAdmissionChecks(checks map[string]AdmissionChec
slices.Sort(inactive)
slices.Sort(flavorIndependentCheckOnFlavors)
slices.Sort(perFlavorMultiKueueChecks)
multiKueueAdmissionChecksList := sets.List(multiKueueAdmissionChecks)
provisioningChecksList := sets.List(provisioningAdmissionChecks)
multiKueueChecks := sets.List(multiKueueAdmissionChecks)
provisioningChecks := sets.List(provisioningAdmissionChecks)

update := false
if !slices.Equal(c.missingAdmissionChecks, missing) {
Expand Down Expand Up @@ -455,13 +455,13 @@ func (c *clusterQueue) updateWithAdmissionChecks(checks map[string]AdmissionChec
}
}

if !slices.Equal(c.multiKueueAdmissionChecks, multiKueueAdmissionChecksList) {
c.multiKueueAdmissionChecks = multiKueueAdmissionChecksList
if !slices.Equal(c.multiKueueAdmissionChecks, multiKueueChecks) {
c.multiKueueAdmissionChecks = multiKueueChecks
update = true
}

if !slices.Equal(c.provisioningAdmissionChecks, provisioningChecksList) {
c.provisioningAdmissionChecks = provisioningChecksList
if !slices.Equal(c.provisioningAdmissionChecks, provisioningChecks) {
c.provisioningAdmissionChecks = provisioningChecks
update = true
}

Expand Down

0 comments on commit 17f5909

Please sign in to comment.