Stage sources via k/release API (krel)

[saschagrunert]

We now stage the sources directly via the API provided by k/release rather than the deprecated push-build.sh script (lives in k/release, too).

Side note: The API has not been e2e tested yet. I hope that we can do this with an additional job in test-infra which uses kubetest2 to periodically stage a built release.

[amwat]

Really love that we are moving away from the push-build script!

FYI if you want to test this locally this flow gets triggered by

kubetest2 gke --build --strategy=make --stage=gs://your-bucket

[saschagrunert]

This is ready for review. PTAL

Unfortunately I was not able to test it locally:

> go run main.go gke --build --strategy=make --stage=gs://kubernetes-release-gcb/kubetest2-test
Error: could not find kubetest2 deployer "gke"

[amwat]

make install and make install-deployer-gke should give you the necessary binaries for local testing.

[saschagrunert]

make install and make install-deployer-gke should give you the necessary binaries for local testing.

Thanks! I think the path for the bazel release tars was wrong there:

kubetest2/pkg/build/make.go

Lines 82 to 86 in 237f174

	func extractBuiltTars() error {
	allBuilds, err := K8sDir("kubernetes", "_output", "gcs-stage")
	if err != nil {
	return err
	}

Fixed it in this PR. Now it seems to work:

> kubetest2 gke \
    --repo-root=$PWD \
    --build \
    --strategy=make \
    --stage=gs://kubernetes-release-gcb/ci/kubetest2
…
INFO[0413] Using Bazel build version
INFO[0413] Found build version: v1.20.0-alpha.1.227_89fdf5e7d3769a
INFO[0413] BuildDir is not set, setting it automatically
INFO[0413] Release is build by bazel, setting BuildDir to bazel-bin/build
INFO[0413] Latest version is v1.20.0-alpha.1.227_89fdf5e7d3769a
INFO[0413] Checking bucket kubernetes-release-gcb for write permissions
INFO[0413] Staging local artifacts
INFO[0413] Cleaning staging dir bazel-bin/build/gcs-stage/v1.20.0-alpha.1.227_89fdf5e7d3769a
INFO[0413] Removing bazel-bin/build/gcs-stage/v1.20.0-alpha.1.227_89fdf5e7d3769a
INFO[0413] Creating bazel-bin/build/gcs-stage/v1.20.0-alpha.1.227_89fdf5e7d3769a
INFO[0413] Copying release tarballs
INFO[0413] Trying to copy dir bazel-bin/build/release-tars to bazel-bin/build/gcs-stage/v1.20.0-alpha.1.227_89fdf5e7d3769a
INFO[0413] Trying to copy file bazel-bin/build/release-tars/.dummy to bazel-bin/build/gcs-stage/v1.20.0-alpha.1.227_89fdf5e7d3769a/.dummy (required: false)
INFO[0413] Copied .dummy
INFO[0413] Trying to copy file bazel-bin/build/release-tars/_client-bin.args to bazel-bin/build/gcs-stage/v1.20.0-alpha.1.227_89fdf5e7d3769a/_client-bin.args (required: false)
INFO[0413] Copied _client-bin.args
INFO[0413] Trying to copy file bazel-bin/build/release-tars/_client-bin.tar to bazel-bin/build/gcs-stage/v1.20.0-alpha.1.227_89fdf5e7d3769a/_client-bin.tar (required: false)
INFO[0414] Copied _client-bin.tar
…
INFO[0557] Done
INFO[0557] Skipping not existing extra dir bazel-bin/build/gcs-stage/v1.20.0-alpha.1.227_89fdf5e7d3769a/extra
INFO[0557] Skipping not existing plain binaries dir bazel-bin/build/release-stage
INFO[0557] Writing checksums
INFO[0557] Writing artifact hashes to SHA256SUMS/SHA512SUMS files
INFO[0702] Trying to copy file SHA256SUMS to bazel-bin/build/gcs-stage/v1.20.0-alpha.1.227_89fdf5e7d3769a/SHA256SUMS (required: true)
INFO[0702] Copied SHA256SUMS
INFO[0702] Trying to copy file SHA512SUMS to bazel-bin/build/gcs-stage/v1.20.0-alpha.1.227_89fdf5e7d3769a/SHA512SUMS (required: true)
INFO[0702] Copied SHA512SUMS
INFO[0702] Hashing files in bazel-bin/build/gcs-stage/v1.20.0-alpha.1.227_89fdf5e7d3769a
INFO[0832] GCS destination is ci/kubetest2/v1.20.0-alpha.1.227_89fdf5e7d3769a
INFO[0832] Pushing release artifacts from bazel-bin/build/gcs-stage/v1.20.0-alpha.1.227_89fdf5e7d3769a to gs://kubernetes-release-gcb/ci/kubetest2/v1.20.0-alpha.1.227_89fdf5e7d3769a
Building synchronization state...
Starting synchronization...
…

Artifacts are located there: https://console.cloud.google.com/storage/browser/kubernetes-release-gcb/ci?pageState=(%22StorageObjectListTable%22:(%22f%22:%22%255B%255D%22))&prefix=&forceOnObjectsSortingFiltering=false

Depends on some fixes to be merged in https://github.com/kubernetes/release/pull/1629/files

[saschagrunert]

Alrigtht, gave it another try with the changed build type:

> kubetest2 gke --repo-root . --build --strategy=make --stage=gs://kubernetes-release-gcb/ci

The build results can be found here: https://console.cloud.google.com/storage/browser/kubernetes-release-gcb/ci?pageState=(%22StorageObjectListTable%22:(%22f%22:%22%255B%255D%22))&prefix=&forceOnObjectsSortingFiltering=false

Another small fix for noupdatelatest is in flight there: kubernetes/release#1638

[saschagrunert]

PTAL @amwat

[amwat]

Let's give this a shot!
nothing is currently using the make strategy. But I'll follow up this with changes to the gce build to start using this.

/lgtm
/approve
/hold

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amwat, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [amwat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[justaugustus]

@saschagrunert -- Once kubernetes/release#1731 merges, can you pull it in here?

The logic for handling GCS suffixes gets fixed in that one.
/hold

[saschagrunert]

@saschagrunert -- Once kubernetes/release#1731 merges, can you pull it in here?

The logic for handling GCS suffixes gets fixed in that one.
/hold

Done 👍

[amwat]

/lgtm

[saschagrunert]

Had to rebase once again to include the latest krel fixes
/unhold

[amwat]

/lgtm