-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix manage-offline-files script - wrong path #9886
fix manage-offline-files script - wrong path #9886
Conversation
|
Welcome @Medosopher! |
Hi @Medosopher. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for your contribution. /ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Medosopher, oomichi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank for the contribution. Looks good to me as well! You would also need to rebase to rekick the CI though. |
1472a0b
to
a5e4bbc
Compare
Rebase done. |
Thanks for solving issues. /lgtm |
fix for the directory path in script so it works even when launched from another directory
Does this PR introduce a user-facing change?: