Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Rocky Linux 9 Support #9212

Merged
merged 1 commit into from
Sep 4, 2022
Merged

Add Rocky Linux 9 Support #9212

merged 1 commit into from
Sep 4, 2022

Conversation

yankay
Copy link
Member

@yankay yankay commented Aug 24, 2022 •
edited by floryut
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Rocky 9 has GA, so the kubespray can support it.

Which issue(s) this PR fixes:
Fixes #9186

Special notes for your reviewer:
Add Rocky/RHEL/Oracle/Alma Linux 9 support in the release note.

Does this PR introduce a user-facing change?:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 24, 2022
@yankay
Copy link
Member Author

yankay commented Aug 24, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 24, 2022
@k8s-ci-robot k8s-ci-robot requested review from EppO and woopstar August 24, 2022 03:33
@yankay yankay force-pushed the add-Rocky-9-support branch from 0a99923 to 0c60411 Compare August 24, 2022 04:54
@yankay
Copy link
Member Author

yankay commented Aug 24, 2022

#9175

@yankay yankay force-pushed the add-Rocky-9-support branch from 0c60411 to e645d15 Compare August 24, 2022 06:21
@floryut
Copy link
Member

floryut commented Aug 24, 2022 •
edited
Loading

I've uploaded the image to quay; your rocky9 job should now work 👍

@yankay
Copy link
Member Author

yankay commented Aug 25, 2022

I've uploaded the image to quay; your rocky9 job should now work 👍

Thank you very much

@yankay yankay force-pushed the add-Rocky-9-support branch 2 times, most recently from 331334c to 642c25d Compare August 30, 2022 01:57
@cristicalin
Copy link
Contributor

Thanks @yankay !

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristicalin, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2022
@floryut
Copy link
Member

floryut commented Aug 30, 2022

@yankay You need to add the test to one of the stages 😄

@yankay yankay force-pushed the add-Rocky-9-support branch from 642c25d to 907ba7d Compare August 30, 2022 08:54
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 30, 2022
@yankay yankay force-pushed the add-Rocky-9-support branch from 23f3116 to 907ba7d Compare August 31, 2022 02:07
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 31, 2022
@yankay yankay force-pushed the add-Rocky-9-support branch from 5775404 to 907ba7d Compare August 31, 2022 02:13
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 31, 2022
@yankay yankay force-pushed the add-Rocky-9-support branch 2 times, most recently from aab8060 to 7e1991c Compare September 2, 2022 03:29
@yankay yankay changed the title Add Rocky Linux 9 Support [WIP] Add Rocky Linux 9 Support Sep 2, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2022
@yankay yankay force-pushed the add-Rocky-9-support branch from 7e1991c to ca71052 Compare September 2, 2022 04:05
@yankay
Copy link
Member Author

yankay commented Sep 2, 2022

I've uploaded the image to quay; your rocky9 job should now work 👍

HI @floryut

When we use the old version of the rockylinux, the CI is broken with the ssh cannot ready.

Luckily, the rockylinux image have been updated at 2022-8-30. So I update it and upload the image to https://hub.docker.com/r/yankay/vm-rockylinux-9 (build with test-infa script) with https://github.com/kubernetes-sigs/kubespray/pull/9212/files#diff-0eb5cbf2ec4592bbeeb3268dbe2b3d71dcb839466e67f73e4c1d09cfd7a8ca45R50.

Would you please update the quay.io/kubespray/vm-rockylinux-9 with docker.io/yankay/vm-rockylinux-9, so that the CI can success.

@yankay yankay force-pushed the add-Rocky-9-support branch 2 times, most recently from 89aece5 to 3251776 Compare September 2, 2022 07:27
@floryut
Copy link
Member

floryut commented Sep 2, 2022 •
edited
Loading

@yankay it's done, (new) image is now pushed to quay

@yankay
Copy link
Member Author

yankay commented Sep 2, 2022

@yankay it's done, (new) image is now pushed to quay

Thank you very much

@yankay yankay force-pushed the add-Rocky-9-support branch 2 times, most recently from 5528b3b to d6fceca Compare September 2, 2022 08:01
@yankay yankay changed the title [WIP] Add Rocky Linux 9 Support Add Rocky Linux 9 Support Sep 2, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2022
@yankay yankay force-pushed the add-Rocky-9-support branch from d6fceca to 7e834e0 Compare September 2, 2022 10:13
@yankay
Copy link
Member Author

yankay commented Sep 4, 2022

HI @oomichi , would you please review it ? :-)

@oomichi
Copy link
Contributor

oomichi commented Sep 4, 2022

@yankay Nice work!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 4, 2022
@k8s-ci-robot k8s-ci-robot merged commit e2f1f8d into kubernetes-sigs:master Sep 4, 2022
@yankay
Copy link
Member Author

yankay commented Sep 5, 2022

Thanks @oomichi

@mr-yaky
Copy link
Contributor

mr-yaky commented Sep 6, 2022

Is it possible to use also with AlmaLinux el9, right ?

@yankay
Copy link
Member Author

yankay commented Sep 16, 2022

Is it possible to use also with AlmaLinux el9, right ?

yes, I think so

@mr-yaky
Copy link
Contributor

mr-yaky commented Sep 26, 2022

cool, thanks

enneitex pushed a commit to enneitex/kubespray that referenced this pull request Jan 25, 2023
@yankay @enneitex
add-Rocky-9-support (kubernetes-sigs#9212)
5e8f00b
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
@yankay @nolimitkun
add-Rocky-9-support (kubernetes-sigs#9212)
5977b7e
@rptaylor rptaylor mentioned this pull request Jun 21, 2023
Closed
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jul 7, 2023
@yankay @LuckySB
add-Rocky-9-support (kubernetes-sigs#9212)
db9815b
@yankay yankay mentioned this pull request Sep 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EppO EppO Awaiting requested review from EppO

@woopstar woopstar Awaiting requested review from woopstar

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rocky Linux 9 Support
6 participants
@yankay @floryut @cristicalin @k8s-ci-robot @oomichi @mr-yaky