-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix wrong template rendering on cilium_ip_masq_agent_enable variable #8933
Conversation
Signed-off-by: mahjonp <[email protected]>
Hi @mahjonp. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for fixing this @mahjonp ! /ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cristicalin, mahjonp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for fixing the issue. /lgtm |
/ok-to-test |
@mahjonp Thank you for your help. |
@oomichi Also, I think this should be added to known issue in release page |
Of course |
Signed-off-by: mahjonp <[email protected]>
Signed-off-by: mahjonp <[email protected]>
Signed-off-by: mahjonp <[email protected]>
Signed-off-by: mahjonp <[email protected]>
Signed-off-by: mahjonp [email protected]
What type of PR is this?
/kind bug
What this PR does / why we need it:
I make a mistake on #8893 as @we10710aa say, hope it hasn't cause too much trouble.
Which issue(s) this PR fixes:
#8893 (comment)
Special notes for your reviewer:
Does this PR introduce a user-facing change?: