Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[calico] add 3.22.3 and 3.23.1 #8897

Merged
merged 2 commits into from
May 31, 2022
Merged

[calico] add 3.22.3 and 3.23.1 #8897

merged 2 commits into from
May 31, 2022

Conversation

DANic-git
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:
This PR

  • upgrades calico 3.22.x to 3.22.3
  • add calico 3.23.1
  • fix download CRDs for calico 3.22.3 and upper

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
Since 3986e4d calico doesn't copy CRDs from libcalico-go.
I fixed the download

Does this PR introduce a user-facing change?:

[calico] upgrade default calico version to v3.22.3

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 30, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @germetist. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 30, 2022
@DANic-git
[calico]
22dbece 
* add 3.22.3 and 3.23.1
* set 3.22.3 default
* fix download crd for calico 3.22.3 and upper
@cristicalin
Copy link
Contributor

Thanks for doing this @germetist , it seems like Calico is making it intentionally more difficult to maintain our own manifests and pushing towards using their official packaging method, we may need to reconsider how we deploy calico in the next releases and just try to embrace their own way of doing things to reduce out maintenance effort.

/ok-to-test
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 31, 2022
@cristicalin cristicalin added this to the 2.19 milestone May 31, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristicalin, germetist

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2022
@oomichi
Copy link
Contributor

oomichi commented May 31, 2022

Please update the calico version on README.md like #8886

@DANic-git
Copy link
Contributor Author

Please update the calico version on README.md like #8886

Done

@oomichi
Copy link
Contributor

oomichi commented May 31, 2022

Please update the calico version on README.md like #8886

Done

Thanks for updating.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2022
@k8s-ci-robot k8s-ci-robot merged commit 5c136ae into kubernetes-sigs:master May 31, 2022
@oomichi oomichi mentioned this pull request May 31, 2022
Closed
@DANic-git DANic-git deleted the calico-v3.22.3 branch June 2, 2022 14:12
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jul 1, 2023
@DANic-git @LuckySB
[calico] add 3.22.3 and 3.23.1 (kubernetes-sigs#8897)
fc57bfc 
* [calico]
* add 3.22.3 and 3.23.1
* set 3.22.3 default
* fix download crd for calico 3.22.3 and upper

* update calico README.md
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 23, 2023
@DANic-git @LuckySB
[calico] add 3.22.3 and 3.23.1 (kubernetes-sigs#8897)
c6b3db2 
* [calico]
* add 3.22.3 and 3.23.1
* set 3.22.3 default
* fix download crd for calico 3.22.3 and upper

* update calico README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristicalin cristicalin Awaiting requested review from cristicalin

@jayonlau jayonlau Awaiting requested review from jayonlau

Assignees

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
2.19
Development

Successfully merging this pull request may close these issues.
4 participants
@DANic-git @k8s-ci-robot @cristicalin @oomichi