Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add hardening guide #8868

Merged
merged 1 commit into from
May 29, 2022
Merged

docs: add hardening guide #8868

merged 1 commit into from
May 29, 2022

Conversation

alegrey91
Copy link
Contributor

@alegrey91 alegrey91 commented May 25, 2022

What type of PR is this?

/kind documentation

What this PR does / why we need it:
The PR provide a brief guide to easily harden the cluster with the latest options added on kubespray.

Which issue(s) this PR fixes:

Fixes #8808

Special notes for your reviewer:
Please, refer to the following discussion: #8773

Does this PR introduce a user-facing change?:

Add Hardening setup guide

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 25, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @alegrey91. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 25, 2022
@k8s-ci-robot k8s-ci-robot requested review from bozzo and liupeng0518 May 25, 2022 16:26
@oomichi
Copy link
Contributor

oomichi commented May 25, 2022

No issue has been opened before.

We already have a corresponding issue #8808 😄

@alegrey91
Copy link
Contributor Author

No issue has been opened before.

We already have a corresponding issue #8808 😄

Sorry, I totally forgot 😅

Copy link
Contributor

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for writing this document, that will be useful for users.
Most part seems good for me, just some comments.

/cc @oomichi

docs/hardening.md Outdated Show resolved Hide resolved
docs/hardening.md Outdated Show resolved Hide resolved
docs/hardening.md Show resolved Hide resolved
docs/hardening.md Outdated Show resolved Hide resolved
docs/hardening.md Outdated Show resolved Hide resolved
docs/hardening.md Outdated Show resolved Hide resolved
docs/hardening.md Outdated Show resolved Hide resolved
docs/hardening.md Outdated Show resolved Hide resolved
docs/hardening.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot requested a review from oomichi May 25, 2022 18:48
@oomichi oomichi added the kind/documentation Categorizes issue or PR as related to documentation. label May 25, 2022
@oomichi
Copy link
Contributor

oomichi commented May 26, 2022

@alegrey91
Thank you so much for your quick reply.
Please update this pull request based on the discussions.

@oomichi
Copy link
Contributor

oomichi commented May 26, 2022

Thanks for updating.
Really nice work @alegrey91 👍

/ok-to-test
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 26, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alegrey91, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2022
@alegrey91
Copy link
Contributor Author

alegrey91 commented May 27, 2022

Really nice work @alegrey91 👍

Thanks @oomichi :)
Seems that a job is in pending state from yesterday 😅

@cristicalin
Copy link
Contributor

Love your recent work @alegrey91 !

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2022
@k8s-ci-robot k8s-ci-robot merged commit d22204a into kubernetes-sigs:master May 29, 2022
@alegrey91
Copy link
Contributor Author

Thanks a lot @cristicalin :)

@oomichi oomichi mentioned this pull request May 29, 2022
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jul 1, 2023
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hardening Setup Guide
4 participants