[etcd] Add support for setting the request size limit #8849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a_backend_bytes` Signed-off-by: necatican <[email protected]>
Signed-off-by: necatican <[email protected]>
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
the
size/S
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cristicalin, necatican The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Closed
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Jun 30, 2023
…s#8849) * [etcd] Add extra documentation for `etcd_memory_limit` and `etcd_quota_backend_bytes` Signed-off-by: necatican <[email protected]> * [etcd] Add support for setting ETCD_MAX_REQUEST_BYTES Signed-off-by: necatican <[email protected]>
LuckySB
pushed a commit
to southbridgeio/kubespray
that referenced
this pull request
Oct 23, 2023
…s#8849) * [etcd] Add extra documentation for `etcd_memory_limit` and `etcd_quota_backend_bytes` Signed-off-by: necatican <[email protected]> * [etcd] Add support for setting ETCD_MAX_REQUEST_BYTES Signed-off-by: necatican <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
etcd supports setting the request size limit. We should support it too.
Which issue(s) this PR fixes:
Fixes #8848
Special notes for your reviewer:
I also added a few comments for the
etcd_memory_limitandetcd_quota_backend_bytesvariables and did not want to create a new PR since these variables are related to the subject of this PR.Does this PR introduce a user-facing change?: