-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix condition on kata_containers_version/kube_version check when kata_containers_enabled is false #8804
Fix condition on kata_containers_version/kube_version check when kata_containers_enabled is false #8804
Conversation
…iners_enabled is false
Hi @emiran-orange. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks @emiran-orange ! /ok-to-test |
Nice catch. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: emiran-orange, oomichi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…iners_enabled is false (kubernetes-sigs#8804)
…iners_enabled is false (kubernetes-sigs#8804)
What type of PR is this?
/kind bug
What this PR does / why we need it:
The check on the compatibility between
kata_containers_version
andkube_version
was performed even if kata containers weren't enabled.This PR adds a condition to the check task on
kata_containers_enabled
.On the way, a small typo has been fixed.
Which issue(s) this PR fixes:
None that I know of
Special notes for your reviewer:
N/A
Does this PR introduce a user-facing change?: